[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2026: Solr native support fixes #1703

[GitBox <gi...@apache.org>]

ppalaga commented on a change in pull request #2026:
URL: https://github.com/apache/camel-quarkus/pull/2026#discussion_r529871737



##########
File path: integration-tests/solr/pom.xml
##########
@@ -80,4 +98,52 @@
         </dependency>
     </dependencies>
 
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-surefire-plugin</artifactId>
+                <configuration>
+                    <systemPropertyVariables>
+                        <!-- force the locale as we want to explicitly test message interpolation -->

Review comment:
       The comment is maybe a leftover and can be removed?

##########
File path: integration-tests/solr/pom.xml
##########
@@ -80,4 +98,52 @@
         </dependency>
     </dependencies>
 
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-surefire-plugin</artifactId>
+                <configuration>
+                    <systemPropertyVariables>
+                        <!-- force the locale as we want to explicitly test message interpolation -->
+                        <javax.net.ssl.trustStore>${solr.trust-store}</javax.net.ssl.trustStore>

Review comment:
       This will not work OotB on the platform, where the tests are run from test jars and the local resources are not available. I see that this also cannot be configured to pull the trust store from the jar, because the system property expects a local file. Hence a special step will be needed on the platform to unpack the test jar and set the trust store accordingly. Maybe we could make creating that preprocessing step easier by some changes here. Let me file a followup for that.

##########
File path: integration-tests/solr/pom.xml
##########
@@ -80,4 +98,52 @@
         </dependency>
     </dependencies>
 
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-surefire-plugin</artifactId>
+                <configuration>
+                    <systemPropertyVariables>
+                        <!-- force the locale as we want to explicitly test message interpolation -->
+                        <javax.net.ssl.trustStore>${solr.trust-store}</javax.net.ssl.trustStore>
+                        <javax.net.ssl.trustStorePassword>${solr.trust-store-password}</javax.net.ssl.trustStorePassword>
+                    </systemPropertyVariables>
+                </configuration>
+            </plugin>
+        </plugins>
+    </build>
+    <profiles>
+        <profile>
+            <id>native</id>
+            <activation>
+                <property>
+                    <name>native</name>
+                </property>
+            </activation>
+            <properties>
+                <quarkus.package.type>native</quarkus.package.type>
+                <quarkus.native.additional-build-args>-H:IncludeResources=.*ssl/.*,-J-Djavax.net.ssl.trustStore=${solr.trust-store},
+                    -J-Djavax.net.ssl.trustStorePassword=${solr.trust-store-password}</quarkus.native.additional-build-args>

Review comment:
       Is there any reason not to put this as `quarkus.native.additional-build-args` to application.properties? Maybe because the local path has to be absolute?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org