You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mpetruska <gi...@git.apache.org> on 2017/11/14 11:15:23 UTC
[GitHub] spark pull request #19744: [SPARK-22267][SQL] [WIP] Spark SQL incorrectly re...
GitHub user mpetruska opened a pull request:
https://github.com/apache/spark/pull/19744
[SPARK-22267][SQL] [WIP] Spark SQL incorrectly reads ORC file when column order is different
## What changes were proposed in this pull request?
Ticket: [SPARK-22267](https://issues.apache.org/jira/browse/SPARK-22267)
## How was this patch tested?
No change yet, please do not merge - only tests were added to clarify the issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mpetruska/spark SPARK-222267
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19744.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19744
----
commit b337692310d4615251a696b30296e4235ddcc1e8
Author: Mark Petruska <pe...@gmail.com>
Date: 2017-11-14T11:12:39Z
adds investigative test cases
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19744: [SPARK-22267][SQL] [WIP] Spark SQL incorrectly re...
Posted by mpetruska <gi...@git.apache.org>.
Github user mpetruska commented on a diff in the pull request:
https://github.com/apache/spark/pull/19744#discussion_r151092639
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala ---
@@ -278,4 +286,93 @@ class OrcSourceSuite extends OrcSuite {
)).get.toString
}
}
+
+ test("SPARK-22267 Spark SQL correctly reads parquet files when column order is different") {
--- End diff --
Will remove this one, it is only used to help me diagnose the problem.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19744: [SPARK-22267][SQL] [WIP] Spark SQL incorrectly reads ORC...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19744
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19744: [SPARK-22267][SQL] [WIP] Spark SQL incorrectly re...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19744#discussion_r150905696
--- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcSourceSuite.scala ---
@@ -278,4 +286,93 @@ class OrcSourceSuite extends OrcSuite {
)).get.toString
}
}
+
+ test("SPARK-22267 Spark SQL correctly reads parquet files when column order is different") {
--- End diff --
SPARK-22267 is not about Parquet. Why do you add this?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19744: [SPARK-22267][SQL] [WIP] Spark SQL incorrectly re...
Posted by mpetruska <gi...@git.apache.org>.
Github user mpetruska closed the pull request at:
https://github.com/apache/spark/pull/19744
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19744: [SPARK-22267][SQL] [WIP] Spark SQL incorrectly reads ORC...
Posted by mpetruska <gi...@git.apache.org>.
Github user mpetruska commented on the issue:
https://github.com/apache/spark/pull/19744
Closing in favour of #19470.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org