You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/04/24 01:14:49 UTC
[kudu-CR] Remove kudu-lint tool
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10170
to review the following change.
Change subject: Remove kudu-lint tool
......................................................................
Remove kudu-lint tool
This tool had fallen far out of date and maintaining it wasn't worth the
incremental benefit. Let's remove it and if we find the need for
Kudu-specific lint checks perhaps we can bring it back some day.
Change-Id: I1fe1df8047dc0f918a8166d181e1061150ba29a5
---
D build-support/tools/kudu-lint/.gitignore
D build-support/tools/kudu-lint/CMakeLists.txt
D build-support/tools/kudu-lint/README
D build-support/tools/kudu-lint/cmake_modules/FindClang.cmake
D build-support/tools/kudu-lint/cmake_modules/FindLLVM.cmake
D build-support/tools/kudu-lint/kudu-lint.cc
6 files changed, 0 insertions(+), 526 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/10170/1
--
To view, visit http://gerrit.cloudera.org:8080/10170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fe1df8047dc0f918a8166d181e1061150ba29a5
Gerrit-Change-Number: 10170
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] Remove kudu-lint tool
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10170 )
Change subject: Remove kudu-lint tool
......................................................................
Patch Set 1: Code-Review+2
End of an era I guess.
--
To view, visit http://gerrit.cloudera.org:8080/10170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1fe1df8047dc0f918a8166d181e1061150ba29a5
Gerrit-Change-Number: 10170
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 24 Apr 2018 01:35:33 +0000
Gerrit-HasComments: No
[kudu-CR] Remove kudu-lint tool
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10170 )
Change subject: Remove kudu-lint tool
......................................................................
Remove kudu-lint tool
This tool had fallen far out of date and maintaining it wasn't worth the
incremental benefit. Let's remove it and if we find the need for
Kudu-specific lint checks perhaps we can bring it back some day.
Change-Id: I1fe1df8047dc0f918a8166d181e1061150ba29a5
Reviewed-on: http://gerrit.cloudera.org:8080/10170
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
D build-support/tools/kudu-lint/.gitignore
D build-support/tools/kudu-lint/CMakeLists.txt
D build-support/tools/kudu-lint/README
D build-support/tools/kudu-lint/cmake_modules/FindClang.cmake
D build-support/tools/kudu-lint/cmake_modules/FindLLVM.cmake
D build-support/tools/kudu-lint/kudu-lint.cc
6 files changed, 0 insertions(+), 526 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fe1df8047dc0f918a8166d181e1061150ba29a5
Gerrit-Change-Number: 10170
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>