[GitHub] [apisix] wayne-cheng commented on a change in pull request #4856: feat: support configurating the node listening address (#4853)

[GitBox <gi...@apache.org>]

wayne-cheng commented on a change in pull request #4856:
URL: https://github.com/apache/apisix/pull/4856#discussion_r692589126



##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -459,11 +459,11 @@ http {
 
     server {
         {% for _, item in ipairs(node_listen) do %}
-        listen {* item.port *} default_server {% if enable_reuseport then %} reuseport {% end %} {% if item.enable_http2 then %} http2 {% end %};
-        {% end %}
-        {% if ssl.enable then %}
+        listen {* item.ip *}:{* item.port *} default_server {% if enable_reuseport then %} reuseport {% end %} {% if item.enable_http2 then %} http2 {% end %};
+        {% if item.allow_ssl and ssl.enable then %}

Review comment:
       ok，and should I explain these params in the doc FAQ.md ?
   ```yaml
   apisix:
     node_listen:
     - 9080
     - port: 9380
       ip: 127.0.0.1            # If not given, the default is `0.0.0.0`.
       enable_ssl: True         # If `False`, the ip connot be ued to enable ssl. If not given, the default is `True`.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org