You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/22 14:59:15 UTC
[GitHub] [superset] cdreier opened a new pull request, #20829: #20828 adding extraConfig to worker deployment
cdreier opened a new pull request, #20829:
URL: https://github.com/apache/superset/pull/20829
Fixes #20828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cdreier commented on a diff in pull request #20829: #20828 adding extraConfig to worker deployment
Posted by GitBox <gi...@apache.org>.
cdreier commented on code in PR #20829:
URL: https://github.com/apache/superset/pull/20829#discussion_r927931237
##########
helm/superset/templates/deployment-worker.yaml:
##########
@@ -130,6 +135,10 @@ spec:
- name: superset-config
secret:
secretName: {{ tpl .Values.configFromSecret . }}
- {{- with .Values.extraVolumes }}
- {{- tpl (toYaml .) $ | nindent 8 -}}
- {{- end }}
+ - name: superset-extra-config
Review Comment:
good catch, i just missed it :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cdreier commented on pull request #20829: fix: adding extraConfig to worker deployment #20828
Posted by GitBox <gi...@apache.org>.
cdreier commented on PR #20829:
URL: https://github.com/apache/superset/pull/20829#issuecomment-1193967673
@craig-rueda is there a chance we get this merged this week? would help us a lot to remove temporary workarounds - or is anything missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #20829: #20828 adding extraConfig to worker deployment
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on PR #20829:
URL: https://github.com/apache/superset/pull/20829#issuecomment-1192754770
@cdreier - can you pls bump the chart version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #20829: fix: adding extraConfig to worker deployment #20828
Posted by GitBox <gi...@apache.org>.
craig-rueda merged PR #20829:
URL: https://github.com/apache/superset/pull/20829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cdreier commented on pull request #20829: #20828 adding extraConfig to worker deployment
Posted by GitBox <gi...@apache.org>.
cdreier commented on PR #20829:
URL: https://github.com/apache/superset/pull/20829#issuecomment-1192870437
thanks a lot for your support and fast response!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on a diff in pull request #20829: #20828 adding extraConfig to worker deployment
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on code in PR #20829:
URL: https://github.com/apache/superset/pull/20829#discussion_r927826634
##########
helm/superset/templates/deployment-worker.yaml:
##########
@@ -130,6 +135,10 @@ spec:
- name: superset-config
secret:
secretName: {{ tpl .Values.configFromSecret . }}
- {{- with .Values.extraVolumes }}
- {{- tpl (toYaml .) $ | nindent 8 -}}
- {{- end }}
+ - name: superset-extra-config
Review Comment:
Looks like this is missing a leading `{{- if .Values.extraConfigs }}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org