You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by mr...@apache.org on 2011/02/08 19:19:14 UTC
svn commit: r1068503 - in /ofbiz/trunk/applications/product:
script/org/ofbiz/product/imagemanagement/ImageManagementServices.xml
servicedef/services.xml
src/org/ofbiz/product/imagemanagement/ImageManagementServices.java
Author: mrisaliti
Date: Tue Feb 8 18:19:14 2011
New Revision: 1068503
URL: http://svn.apache.org/viewvc?rev=1068503&view=rev
Log:
Remove an unused variable of ImageManagementServices.xml instead of declaring a FIXME (OFBIZ-4102)
Modified:
ofbiz/trunk/applications/product/script/org/ofbiz/product/imagemanagement/ImageManagementServices.xml
ofbiz/trunk/applications/product/servicedef/services.xml
ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java
Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/imagemanagement/ImageManagementServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/script/org/ofbiz/product/imagemanagement/ImageManagementServices.xml?rev=1068503&r1=1068502&r2=1068503&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/script/org/ofbiz/product/imagemanagement/ImageManagementServices.xml (original)
+++ ofbiz/trunk/applications/product/script/org/ofbiz/product/imagemanagement/ImageManagementServices.xml Tue Feb 8 18:19:14 2011
@@ -183,7 +183,6 @@ under the License.
<field-map field-name="dataResourceId" from-field="dataResourceId"/>
</entity-one>
- <set field="removeImageFile.productId" from-field="parameters.productId"/>
<set field="removeImageFile.contentId" from-field="parameters.contentId"/>
<set field="removeImageFile.objectInfo" from-field="dataResource.objectInfo"/>
<set-service-fields service-name="removeImageFileForImageManagement" map="removeImageFile" to-map="removeImageFileMap"/>
Modified: ofbiz/trunk/applications/product/servicedef/services.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/servicedef/services.xml?rev=1068503&r1=1068502&r2=1068503&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/servicedef/services.xml (original)
+++ ofbiz/trunk/applications/product/servicedef/services.xml Tue Feb 8 18:19:14 2011
@@ -1408,7 +1408,6 @@ under the License.
<description>Delete Image File</description>
<attribute mode="IN" name="contentId" optional="false" type="String"/>
<attribute mode="IN" name="objectInfo" optional="false" type="String"/>
- <attribute mode="IN" name="productId" optional="false" type="String"/>
</service>
<service name="addImageFrame" engine="java"
Modified: ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java?rev=1068503&r1=1068502&r2=1068503&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java (original)
+++ ofbiz/trunk/applications/product/src/org/ofbiz/product/imagemanagement/ImageManagementServices.java Tue Feb 8 18:19:14 2011
@@ -307,8 +307,7 @@ public class ImageManagementServices {
public static Map<String, Object> removeImageFileForImageManagement(DispatchContext dctx, Map<String, ? extends Object> context){
String contentId = (String) context.get("contentId");
String objectInfo = (String) context.get("objectInfo");
- //FIXME can be removed ?
- // String productId = (String) context.get("productId");
+
try {
if (UtilValidate.isNotEmpty(contentId)) {
String imageServerPath = FlexibleStringExpander.expandString(UtilProperties.getPropertyValue("catalog", "image.server.path"), context);