You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by al...@apache.org on 2023/10/02 11:00:50 UTC

[arrow-datafusion] branch main updated: Minor: Add comment explaining why verify benchmark results uses release mode (#7712)

This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git


The following commit(s) were added to refs/heads/main by this push:
     new 2ab0c0005f Minor: Add comment explaining why verify benchmark results uses release mode (#7712)
2ab0c0005f is described below

commit 2ab0c0005f5aa9c835a0d7173bf7b6fec6ad191b
Author: Andrew Lamb <an...@nerdnetworks.org>
AuthorDate: Mon Oct 2 07:00:43 2023 -0400

    Minor: Add comment explaining why verify benchmark results uses release mode (#7712)
    
    While looking into https://github.com/apache/arrow-datafusion/issues/7709 I discovered why this test is run in release mode, and I wanted to leave a note for my future self
---
 .github/workflows/rust.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 0f572c9687..27fdc9e370 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -241,6 +241,7 @@ jobs:
       - name: Verify that benchmark queries return expected results
         run: |
           export TPCH_DATA=`realpath datafusion/sqllogictest/test_files/tpch/data`
+          # use release build for plan verificaton because debug build causes stack overflow
           cargo test plan_q --package datafusion-benchmarks --profile release-nonlto --features=ci -- --test-threads=1
           INCLUDE_TPCH=true cargo test --test sqllogictests
       - name: Verify Working Directory Clean