You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/02 03:46:55 UTC

[GitHub] [incubator-kyuubi] deadwind4 commented on a diff in pull request #3173: [KYUUBI #3172][FLINK] Fix failed test cases in Flink 1.15

deadwind4 commented on code in PR #3173:
URL: https://github.com/apache/incubator-kyuubi/pull/3173#discussion_r935087550


##########
externals/kyuubi-flink-sql-engine/src/test/scala/org/apache/kyuubi/engine/flink/operation/FlinkOperationSuite.scala:
##########
@@ -606,8 +609,9 @@ class FlinkOperationSuite extends WithFlinkSQLEngine with HiveJDBCTestHelper {
     withJdbcStatement() { statement =>
       val resultSet = statement.executeQuery("select encode('kyuubi', 'UTF-8')")
       assert(resultSet.next())
+      // Adapt to Flink 1.15
       assert(
-        resultSet.getString(1) == "kyuubi")
+        resultSet.getString(1) == "kyuubi" || resultSet.getString(1) == "k")

Review Comment:
   This is a Flink native bug, we need to fix flink itself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org