You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rp...@apache.org on 2016/04/12 17:00:22 UTC
[3/6] logging-log4j2 git commit: LOG4J2-1343 removed outdated
comment: the new implementation does not have this problem (still not
enabling gc-free sockets for now...)
LOG4J2-1343 removed outdated comment: the new implementation does not have this problem (still not enabling gc-free sockets for now...)
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/8d7bf48d
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/8d7bf48d
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/8d7bf48d
Branch: refs/heads/LOG4J2-1343-no-gc-os-appenders-bytebuffered
Commit: 8d7bf48d251c18d42285ec85ebecdf77a152f06a
Parents: c99f4aa
Author: rpopma <rp...@apache.org>
Authored: Tue Apr 12 22:22:09 2016 +0900
Committer: rpopma <rp...@apache.org>
Committed: Tue Apr 12 22:22:09 2016 +0900
----------------------------------------------------------------------
.../java/org/apache/logging/log4j/core/appender/SocketAppender.java | 1 -
1 file changed, 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/8d7bf48d/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SocketAppender.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SocketAppender.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SocketAppender.java
index 6d0221e..1a542db 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SocketAppender.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/appender/SocketAppender.java
@@ -248,7 +248,6 @@ public class SocketAppender extends AbstractOutputStreamAppender<AbstractSocketM
@Override
protected void directEncodeEvent(final LogEvent event) {
// Disable garbage-free logging for now:
- // problem with TCP: synchronization on manager in Reconnector thread would give deadlock.
// problem with UDP: 8K buffer size means that largish messages get broken up into chunks
writeByteArrayToManager(event); // revert to classic (non-garbage free) logging
}