[GitHub] [airflow] o-nikolas commented on a diff in pull request #28755: Add a new SSM hook and use it in the System Test context builder

[GitBox <gi...@apache.org>]

o-nikolas commented on code in PR #28755:
URL: https://github.com/apache/airflow/pull/28755#discussion_r1067757109


##########
tests/system/providers/amazon/aws/utils/__init__.py:
##########
@@ -92,15 +93,15 @@ def _fetch_from_ssm(key: str, test_name: str | None = None) -> str:
     :return: The value of the provided key from SSM
     """
     _test_name: str = test_name if test_name else _get_test_name()
-    ssm_client: BaseClient = boto3.client("ssm")
+    hook = SsmHook()

Review Comment:
   I don't love changing the "prod" code in this way to make the tests pass (I think the expectations in that unit test should be updated for AWS examples). But on the other hand the "prod" code here is technically also test code, so it's not so bad and it's a clean change :+1: Happy to merge!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org