You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/06/25 18:29:26 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #9611: Minor fix for libc/pwd
xiaoxiang781216 opened a new pull request, #9611:
URL: https://github.com/apache/nuttx/pull/9611
## Summary
- libc/pwd: Reuse g_passwd and g_passwd_buffer in getpwbuf
- libc/pwd: Correct the geos related comment and ddd ROOT_GEOS macro
## Impact
code refactor
## Testing
ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] patacongo commented on a diff in pull request #9611: Minor fix for libc/pwd
Posted by "patacongo (via GitHub)" <gi...@apache.org>.
patacongo commented on code in PR #9611:
URL: https://github.com/apache/nuttx/pull/9611#discussion_r1242314678
##########
libs/libc/pwd/lib_find_pwdfile.c:
##########
@@ -133,13 +133,14 @@ static int pwd_foreach(pwd_foreach_match_t match, uintptr_t arg,
*
* The format of the password file is:
*
- * user:x:uid:uid:home
+ * user:x:uid:uid:geos:home
*
* Where:
* user: User name
* x: Encrypted password
* uid: User ID
* uid: Group ID
+ * geos： User information
Review Comment:
There appears to be a TAB character after "geos:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9611: Minor fix for libc/pwd
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #9611:
URL: https://github.com/apache/nuttx/pull/9611#discussion_r1242292143
##########
libs/libc/pwd/lib_find_pwdfile.c:
##########
@@ -133,13 +133,14 @@ static int pwd_foreach(pwd_foreach_match_t match, uintptr_t arg,
*
* The format of the password file is:
*
- * user:x:uid:uid:home
+ * user:x:uid:uid:geos:home
*
* Where:
* user: User name
* x: Encrypted password
* uid: User ID
* uid: Group ID
+ * geos： User information
Review Comment:
Something is still wrong. Probably some special symbol used. Let me post another suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9611: Minor fix for libc/pwd
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9611:
URL: https://github.com/apache/nuttx/pull/9611#discussion_r1242332123
##########
libs/libc/pwd/lib_find_pwdfile.c:
##########
@@ -133,13 +133,14 @@ static int pwd_foreach(pwd_foreach_match_t match, uintptr_t arg,
*
* The format of the password file is:
*
- * user:x:uid:uid:home
+ * user:x:uid:uid:geos:home
*
* Where:
* user: User name
* x: Encrypted password
* uid: User ID
* uid: Group ID
+ * geos： User information
* home: Login directory
Review Comment:
Ok, I found the reason, I use the wrong `:`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9611: Minor fix for libc/pwd
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #9611:
URL: https://github.com/apache/nuttx/pull/9611#discussion_r1241266517
##########
libs/libc/pwd/lib_find_pwdfile.c:
##########
@@ -133,13 +133,14 @@ static int pwd_foreach(pwd_foreach_match_t match, uintptr_t arg,
*
* The format of the password file is:
*
- * user:x:uid:uid:home
+ * user:x:uid:uid:geos:home
*
* Where:
* user: User name
* x: Encrypted password
* uid: User ID
* uid: Group ID
+ * geos： User information
Review Comment:
```suggestion
* geos： User information
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] patacongo commented on a diff in pull request #9611: Minor fix for libc/pwd
Posted by "patacongo (via GitHub)" <gi...@apache.org>.
patacongo commented on code in PR #9611:
URL: https://github.com/apache/nuttx/pull/9611#discussion_r1242314678
##########
libs/libc/pwd/lib_find_pwdfile.c:
##########
@@ -133,13 +133,14 @@ static int pwd_foreach(pwd_foreach_match_t match, uintptr_t arg,
*
* The format of the password file is:
*
- * user:x:uid:uid:home
+ * user:x:uid:uid:geos:home
*
* Where:
* user: User name
* x: Encrypted password
* uid: User ID
* uid: Group ID
+ * geos： User information
Review Comment:
There appears to be a TAB character after "geos:" No, garbage, not a TAB:
295 00001260: 6f 75 70 20 49 44 0a 20 20 20 2a 20 20 20 67 65 oup ID. * ge
296 00001270: 6f 73 ef bc 9a 20 55 73 65 72 20 69 6e 66 6f 72 os... User infor
^^^^^^^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis merged pull request #9611: Minor fix for libc/pwd
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #9611:
URL: https://github.com/apache/nuttx/pull/9611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9611: Minor fix for libc/pwd
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #9611:
URL: https://github.com/apache/nuttx/pull/9611#discussion_r1242292793
##########
libs/libc/pwd/lib_find_pwdfile.c:
##########
@@ -133,13 +133,14 @@ static int pwd_foreach(pwd_foreach_match_t match, uintptr_t arg,
*
* The format of the password file is:
*
- * user:x:uid:uid:home
+ * user:x:uid:uid:geos:home
*
* Where:
* user: User name
* x: Encrypted password
* uid: User ID
* uid: Group ID
+ * geos： User information
* home: Login directory
Review Comment:
```suggestion
* uid: Group ID
* geos: User information
* home: Login directory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9611: Minor fix for libc/pwd
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #9611:
URL: https://github.com/apache/nuttx/pull/9611#discussion_r1242289089
##########
libs/libc/pwd/lib_find_pwdfile.c:
##########
@@ -133,13 +133,14 @@ static int pwd_foreach(pwd_foreach_match_t match, uintptr_t arg,
*
* The format of the password file is:
*
- * user:x:uid:uid:home
+ * user:x:uid:uid:geos:home
*
* Where:
* user: User name
* x: Encrypted password
* uid: User ID
* uid: Group ID
+ * geos： User information
Review Comment:
Maybe a bug in my previewer. If it is aligned let's keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9611: Minor fix for libc/pwd
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #9611:
URL: https://github.com/apache/nuttx/pull/9611#discussion_r1242348196
##########
libs/libc/pwd/lib_find_pwdfile.c:
##########
@@ -133,13 +133,14 @@ static int pwd_foreach(pwd_foreach_match_t match, uintptr_t arg,
*
* The format of the password file is:
*
- * user:x:uid:uid:home
+ * user:x:uid:uid:geos:home
*
* Where:
* user: User name
* x: Encrypted password
* uid: User ID
* uid: Group ID
+ * geos： User information
* home: Login directory
Review Comment:
Now all previews well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #9611: Minor fix for libc/pwd
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #9611:
URL: https://github.com/apache/nuttx/pull/9611#discussion_r1241816544
##########
libs/libc/pwd/lib_find_pwdfile.c:
##########
@@ -133,13 +133,14 @@ static int pwd_foreach(pwd_foreach_match_t match, uintptr_t arg,
*
* The format of the password file is:
*
- * user:x:uid:uid:home
+ * user:x:uid:uid:geos:home
*
* Where:
* user: User name
* x: Encrypted password
* uid: User ID
* uid: Group ID
+ * geos： User information
Review Comment:
But why you suggest to not align with other line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org