You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2021/08/09 15:39:51 UTC
[GitHub] [parquet-mr] belugabehr opened a new pull request #917: PARQUET-2063: Remove Compile Warnings from MemoryManager
belugabehr opened a new pull request #917:
URL: https://github.com/apache/parquet-mr/pull/917
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/PARQUET-2063) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky merged pull request #917: PARQUET-2063: Remove Compile Warnings from MemoryManager
Posted by GitBox <gi...@apache.org>.
gszadovszky merged pull request #917:
URL: https://github.com/apache/parquet-mr/pull/917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] belugabehr commented on a change in pull request #917: PARQUET-2063: Remove Compile Warnings from MemoryManager
Posted by GitBox <gi...@apache.org>.
belugabehr commented on a change in pull request #917:
URL: https://github.com/apache/parquet-mr/pull/917#discussion_r664571789
##########
File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetMemoryManagerRuntimeException.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.parquet.hadoop;
+
+import org.apache.parquet.ParquetRuntimeException;
+
+/**
+ * Signals that an exception of some sort has occurred with the Parquet Memory
+ * Manager.
+ *
+ * @see MemoryManager
+ */
+public class ParquetMemoryManagerRuntimeException
+ extends ParquetRuntimeException {
+
+ private static final long serialVersionUID = 1L;
+
+ public ParquetMemoryManagerRuntimeException(String format) {
Review comment:
Good catch. Thanks. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #917: PARQUET-2063: Remove Compile Warnings from MemoryManager
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #917:
URL: https://github.com/apache/parquet-mr/pull/917#issuecomment-876252083
I've restarted the Travis build the second time. Not sure why it fails, there are no logs at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky closed pull request #917: PARQUET-2063: Remove Compile Warnings from MemoryManager
Posted by GitBox <gi...@apache.org>.
gszadovszky closed pull request #917:
URL: https://github.com/apache/parquet-mr/pull/917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #917: PARQUET-2063: Remove Compile Warnings from MemoryManager
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on a change in pull request #917:
URL: https://github.com/apache/parquet-mr/pull/917#discussion_r663729779
##########
File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetMemoryManagerRuntimeException.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.parquet.hadoop;
+
+import org.apache.parquet.ParquetRuntimeException;
+
+/**
+ * Signals that an exception of some sort has occurred with the Parquet Memory
+ * Manager.
+ *
+ * @see MemoryManager
+ */
+public class ParquetMemoryManagerRuntimeException
+ extends ParquetRuntimeException {
+
+ private static final long serialVersionUID = 1L;
+
+ public ParquetMemoryManagerRuntimeException(String format) {
Review comment:
The argument naming is a bit misleading. `message` or similar would be a better choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] shangxinli commented on pull request #917: PARQUET-2063: Remove Compile Warnings from MemoryManager
Posted by GitBox <gi...@apache.org>.
shangxinli commented on pull request #917:
URL: https://github.com/apache/parquet-mr/pull/917#issuecomment-878665045
> I've restarted the Travis build the second time. Not sure why it fails, there are no logs at all.
Yeah, I am seeing the same error in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on pull request #917: PARQUET-2063: Remove Compile Warnings from MemoryManager
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on pull request #917:
URL: https://github.com/apache/parquet-mr/pull/917#issuecomment-895328429
Since the Travis should be fixed now I'm re-triggering all tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #917: PARQUET-2063: Remove Compile Warnings from MemoryManager
Posted by GitBox <gi...@apache.org>.
gszadovszky commented on a change in pull request #917:
URL: https://github.com/apache/parquet-mr/pull/917#discussion_r663729779
##########
File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetMemoryManagerRuntimeException.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.parquet.hadoop;
+
+import org.apache.parquet.ParquetRuntimeException;
+
+/**
+ * Signals that an exception of some sort has occurred with the Parquet Memory
+ * Manager.
+ *
+ * @see MemoryManager
+ */
+public class ParquetMemoryManagerRuntimeException
+ extends ParquetRuntimeException {
+
+ private static final long serialVersionUID = 1L;
+
+ public ParquetMemoryManagerRuntimeException(String format) {
Review comment:
The argument naming is a bit misleading. `message` or similar would be a better choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org