You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jason Fehr (Code Review)" <ge...@cloudera.org> on 2024/03/27 00:05:58 UTC
[Impala-ASF-CR] IMPALA-12824: Removes the prettyprint duration Built-in Function
Jason Fehr has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21208
Change subject: IMPALA-12824: Removes the prettyprint_duration Built-in Function
......................................................................
IMPALA-12824: Removes the prettyprint_duration Built-in Function
The prettyprint_duration function was originally
implemented to work with the workload management tables
which stored durations in integer nanoseconds. These tables
have changed to store decimal seconds.
The prettyprint_duration function would have required a
large investment of time to make it work with decimal
values, and since the new format is more human readable
anyways, this function has been removed.
Change-Id: If2154c2ed9a7217ed4b7587adeae87df55ff03dc
---
M be/src/benchmarks/expr-benchmark.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/string-functions-ir.cc
M be/src/exprs/string-functions.h
M common/function-registry/impala_functions.py
M docs/topics/impala_functions.xml
M docs/topics/impala_string_functions.xml
D testdata/workloads/functional-query/queries/QueryTest/prettyprint-duration.test
D tests/query_test/test_prettyprint_duration.py
9 files changed, 2 insertions(+), 272 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/21208/1
--
To view, visit http://gerrit.cloudera.org:8080/21208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2154c2ed9a7217ed4b7587adeae87df55ff03dc
Gerrit-Change-Number: 21208
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
[Impala-ASF-CR] IMPALA-12824: Removes the prettyprint duration Built-in Function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21208 )
Change subject: IMPALA-12824: Removes the prettyprint_duration Built-in Function
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10445/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/21208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2154c2ed9a7217ed4b7587adeae87df55ff03dc
Gerrit-Change-Number: 21208
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 01:51:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12824: Removes the prettyprint duration Built-in Function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21208 )
Change subject: IMPALA-12824: Removes the prettyprint_duration Built-in Function
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2154c2ed9a7217ed4b7587adeae87df55ff03dc
Gerrit-Change-Number: 21208
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 01:51:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12824: Removes the prettyprint duration Built-in Function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21208 )
Change subject: IMPALA-12824: Removes the prettyprint_duration Built-in Function
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2154c2ed9a7217ed4b7587adeae87df55ff03dc
Gerrit-Change-Number: 21208
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 06:58:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12824: Removes the prettyprint duration Built-in Function
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21208 )
Change subject: IMPALA-12824: Removes the prettyprint_duration Built-in Function
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/21208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2154c2ed9a7217ed4b7587adeae87df55ff03dc
Gerrit-Change-Number: 21208
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Mar 2024 01:51:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12824: Removes the prettyprint duration Built-in Function
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21208
to look at the new patch set (#2).
Change subject: IMPALA-12824: Removes the prettyprint_duration Built-in Function
......................................................................
IMPALA-12824: Removes the prettyprint_duration Built-in Function
The prettyprint_duration function was originally
implemented in IMPALA-12824 to work with the workload
management tables which stored durations in integer
nanoseconds. These tables have changed to store decimal
seconds.
The prettyprint_duration function would have required a
large investment of time to make it work with decimal
values, and since the new format is more human readable
anyways, this function has been removed.
Change-Id: If2154c2ed9a7217ed4b7587adeae87df55ff03dc
---
M be/src/benchmarks/expr-benchmark.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/string-functions-ir.cc
M be/src/exprs/string-functions.h
M common/function-registry/impala_functions.py
M docs/topics/impala_functions.xml
M docs/topics/impala_string_functions.xml
D testdata/workloads/functional-query/queries/QueryTest/prettyprint-duration.test
D tests/query_test/test_prettyprint_duration.py
9 files changed, 2 insertions(+), 272 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/21208/2
--
To view, visit http://gerrit.cloudera.org:8080/21208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If2154c2ed9a7217ed4b7587adeae87df55ff03dc
Gerrit-Change-Number: 21208
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12824: Removes the prettyprint duration Built-in Function
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21208 )
Change subject: IMPALA-12824: Removes the prettyprint_duration Built-in Function
......................................................................
IMPALA-12824: Removes the prettyprint_duration Built-in Function
The prettyprint_duration function was originally
implemented in IMPALA-12824 to work with the workload
management tables which stored durations in integer
nanoseconds. These tables have changed to store decimal
seconds.
The prettyprint_duration function would have required a
large investment of time to make it work with decimal
values, and since the new format is more human readable
anyways, this function has been removed.
Change-Id: If2154c2ed9a7217ed4b7587adeae87df55ff03dc
Reviewed-on: http://gerrit.cloudera.org:8080/21208
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/benchmarks/expr-benchmark.cc
M be/src/exprs/expr-test.cc
M be/src/exprs/string-functions-ir.cc
M be/src/exprs/string-functions.h
M common/function-registry/impala_functions.py
M docs/topics/impala_functions.xml
M docs/topics/impala_string_functions.xml
D testdata/workloads/functional-query/queries/QueryTest/prettyprint-duration.test
D tests/query_test/test_prettyprint_duration.py
9 files changed, 2 insertions(+), 272 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/21208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If2154c2ed9a7217ed4b7587adeae87df55ff03dc
Gerrit-Change-Number: 21208
Gerrit-PatchSet: 4
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-12824: Removes the prettyprint duration Built-in Function
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21208 )
Change subject: IMPALA-12824: Removes the prettyprint_duration Built-in Function
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/21208/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/21208/1//COMMIT_MSG@9
PS1, Line 9: The prettyprint_duration function was originally
: implemented to work with the workload management tables
: which stored durations in integer nanoseconds. These tables
: have changed to store decimal seconds.
nit: Mention IMPALA-12824 in commit message.
--
To view, visit http://gerrit.cloudera.org:8080/21208
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2154c2ed9a7217ed4b7587adeae87df55ff03dc
Gerrit-Change-Number: 21208
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Mar 2024 20:29:09 +0000
Gerrit-HasComments: Yes