You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/05/20 23:48:14 UTC
Review Request: Refactored zookeeper_tests.cpp into
master_detector_tests.cpp and group_tests.cpp.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11266/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Description
-------
See summary.
Diffs
-----
src/Makefile.am 343a7c5288e83d20dc6dd4db5353499199b90cb1
src/tests/group_tests.cpp PRE-CREATION
src/tests/master_detector_tests.cpp 521f0279b165f5d3639788ff6a00b772e6f71b7a
src/tests/zookeeper_test.hpp b5215b00973c9168f681832085bb29f6a8db8160
src/tests/zookeeper_tests.cpp e9180bfd35ee4477849d3a776c29eff5206d66e9
Diff: https://reviews.apache.org/r/11266/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Refactored zookeeper_tests.cpp into
master_detector_tests.cpp and group_tests.cpp.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On May 21, 2013, 9:46 p.m., Vinod Kone wrote:
> > src/tests/master_detector_tests.cpp, lines 19-21
> > <https://reviews.apache.org/r/11266/diff/1/?file=294223#file294223line19>
> >
> > reorder?
?
> On May 21, 2013, 9:46 p.m., Vinod Kone wrote:
> > src/tests/master_detector_tests.cpp, lines 45-47
> > <https://reviews.apache.org/r/11266/diff/1/?file=294223#file294223line45>
> >
> > reorder
Thanks!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11266/#review20859
-----------------------------------------------------------
On May 20, 2013, 9:48 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11266/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 9:48 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 343a7c5288e83d20dc6dd4db5353499199b90cb1
> src/tests/group_tests.cpp PRE-CREATION
> src/tests/master_detector_tests.cpp 521f0279b165f5d3639788ff6a00b772e6f71b7a
> src/tests/zookeeper_test.hpp b5215b00973c9168f681832085bb29f6a8db8160
> src/tests/zookeeper_tests.cpp e9180bfd35ee4477849d3a776c29eff5206d66e9
>
> Diff: https://reviews.apache.org/r/11266/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Refactored zookeeper_tests.cpp into
master_detector_tests.cpp and group_tests.cpp.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11266/#review20859
-----------------------------------------------------------
Ship it!
src/tests/master_detector_tests.cpp
<https://reviews.apache.org/r/11266/#comment42968>
reorder?
src/tests/master_detector_tests.cpp
<https://reviews.apache.org/r/11266/#comment42966>
reorder
- Vinod Kone
On May 20, 2013, 9:48 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11266/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 9:48 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 343a7c5288e83d20dc6dd4db5353499199b90cb1
> src/tests/group_tests.cpp PRE-CREATION
> src/tests/master_detector_tests.cpp 521f0279b165f5d3639788ff6a00b772e6f71b7a
> src/tests/zookeeper_test.hpp b5215b00973c9168f681832085bb29f6a8db8160
> src/tests/zookeeper_tests.cpp e9180bfd35ee4477849d3a776c29eff5206d66e9
>
> Diff: https://reviews.apache.org/r/11266/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>