You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Andrew MacBean (Created) (JIRA)" <ji...@apache.org> on 2011/10/11 15:57:11 UTC
[jira] [Created] (QPID-3542) Java client does not ack non-matching
messages when using client side selectors (CPP Broker)
Java client does not ack non-matching messages when using client side selectors (CPP Broker)
--------------------------------------------------------------------------------------------
Key: QPID-3542
URL: https://issues.apache.org/jira/browse/QPID-3542
Project: Qpid
Issue Type: Sub-task
Components: Java Client
Affects Versions: 0.13
Reporter: Andrew MacBean
Assignee: Andrew MacBean
For topic destinations when client side selectors are in-use, the Java client must ack all messages that do not match the JMS selector. Presently this does not happen and the messages remain un-ack'd on the CPP Broker.
The defect does not manifest itself on the Java Broker as it uses server side selectors nor the non-0.10 code paths.
Investigation has shown that the defect is due to a contradiction in the logic with the checkPreConditions method of BasicMessageConsumer_0_10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3542) Java client does not ack non-matching
messages when using client side selectors (CPP Broker)
Posted by "Andrew MacBean (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean updated QPID-3542:
---------------------------------
Attachment: 0001-QPID-3542-ensure-session-complete-sent-for-filtered-.patch
> Java client does not ack non-matching messages when using client side selectors (CPP Broker)
> --------------------------------------------------------------------------------------------
>
> Key: QPID-3542
> URL: https://issues.apache.org/jira/browse/QPID-3542
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Client
> Affects Versions: 0.13
> Reporter: Andrew MacBean
> Assignee: Andrew MacBean
> Attachments: 0001-QPID-3542-Java-client-does-not-ack-non-matching-mess.patch, 0001-QPID-3542-ensure-session-complete-sent-for-filtered-.patch
>
>
> For topic destinations when client side selectors are in-use, the Java client must ack all messages that do not match the JMS selector. Presently this does not happen and the messages remain un-ack'd on the CPP Broker.
> The defect does not manifest itself on the Java Broker as it uses server side selectors nor the non-0.10 code paths.
> Investigation has shown that the defect is due to a contradiction in the logic with the checkPreConditions method of BasicMessageConsumer_0_10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Reopened] (QPID-3542) Java client does not ack non-matching
messages when using client side selectors (CPP Broker)
Posted by "Keith Wall (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reopened QPID-3542:
------------------------------
Reopening as behaviour in the following scenario is not correct: In the case where client side filtering is in use, and the message has not been pre-acquired, 0-10 requires us to mark the command as completed. This is not happening. This is not a regression as this was not happening prior to this commit.
Secondly the principle behind the new system TopicSessionTest#testNonMatchingMessagesHandledCorrectlly is flawed. It relies on changing the selector to demonstrate that the message remained on the Broker, but changing the selector should "[be] equivalent to unsubscribing (deleting) the old one and creating a new one" (JMS Javadoc : http://download.oracle.com/javaee/6/api/javax/jms/Session.html#createDurableSubscriber(javax.jms.Topic,%20java.lang.String,%20java.lang.String,%20boolean)).
> Java client does not ack non-matching messages when using client side selectors (CPP Broker)
> --------------------------------------------------------------------------------------------
>
> Key: QPID-3542
> URL: https://issues.apache.org/jira/browse/QPID-3542
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Client
> Affects Versions: 0.13
> Reporter: Andrew MacBean
> Assignee: Andrew MacBean
> Attachments: 0001-QPID-3542-Java-client-does-not-ack-non-matching-mess.patch
>
>
> For topic destinations when client side selectors are in-use, the Java client must ack all messages that do not match the JMS selector. Presently this does not happen and the messages remain un-ack'd on the CPP Broker.
> The defect does not manifest itself on the Java Broker as it uses server side selectors nor the non-0.10 code paths.
> Investigation has shown that the defect is due to a contradiction in the logic with the checkPreConditions method of BasicMessageConsumer_0_10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3542) Java client does not ack non-matching
messages when using client side selectors (CPP Broker)
Posted by "Andrew MacBean (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean reassigned QPID-3542:
------------------------------------
Assignee: Keith Wall (was: Andrew MacBean)
Keith please review new patch and apply if happy.
> Java client does not ack non-matching messages when using client side selectors (CPP Broker)
> --------------------------------------------------------------------------------------------
>
> Key: QPID-3542
> URL: https://issues.apache.org/jira/browse/QPID-3542
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Client
> Affects Versions: 0.13
> Reporter: Andrew MacBean
> Assignee: Keith Wall
> Attachments: 0001-QPID-3542-Java-client-does-not-ack-non-matching-mess.patch, 0001-QPID-3542-ensure-session-complete-sent-for-filtered-.patch
>
>
> For topic destinations when client side selectors are in-use, the Java client must ack all messages that do not match the JMS selector. Presently this does not happen and the messages remain un-ack'd on the CPP Broker.
> The defect does not manifest itself on the Java Broker as it uses server side selectors nor the non-0.10 code paths.
> Investigation has shown that the defect is due to a contradiction in the logic with the checkPreConditions method of BasicMessageConsumer_0_10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3542) Java client does not ack non-matching
messages when using client side selectors (CPP Broker)
Posted by "Andrew MacBean (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean updated QPID-3542:
---------------------------------
Status: Ready To Review (was: In Progress)
> Java client does not ack non-matching messages when using client side selectors (CPP Broker)
> --------------------------------------------------------------------------------------------
>
> Key: QPID-3542
> URL: https://issues.apache.org/jira/browse/QPID-3542
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Client
> Affects Versions: 0.13
> Reporter: Andrew MacBean
> Assignee: Keith Wall
> Attachments: 0001-QPID-3542-Java-client-does-not-ack-non-matching-mess.patch
>
>
> For topic destinations when client side selectors are in-use, the Java client must ack all messages that do not match the JMS selector. Presently this does not happen and the messages remain un-ack'd on the CPP Broker.
> The defect does not manifest itself on the Java Broker as it uses server side selectors nor the non-0.10 code paths.
> Investigation has shown that the defect is due to a contradiction in the logic with the checkPreConditions method of BasicMessageConsumer_0_10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3542) Java client does not ack non-matching
messages when using client side selectors (CPP Broker)
Posted by "Andrew MacBean (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean updated QPID-3542:
---------------------------------
Attachment: 0001-QPID-3542-Java-client-does-not-ack-non-matching-mess.patch
Please review and apply if happy.
> Java client does not ack non-matching messages when using client side selectors (CPP Broker)
> --------------------------------------------------------------------------------------------
>
> Key: QPID-3542
> URL: https://issues.apache.org/jira/browse/QPID-3542
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Client
> Affects Versions: 0.13
> Reporter: Andrew MacBean
> Assignee: Andrew MacBean
> Attachments: 0001-QPID-3542-Java-client-does-not-ack-non-matching-mess.patch
>
>
> For topic destinations when client side selectors are in-use, the Java client must ack all messages that do not match the JMS selector. Presently this does not happen and the messages remain un-ack'd on the CPP Broker.
> The defect does not manifest itself on the Java Broker as it uses server side selectors nor the non-0.10 code paths.
> Investigation has shown that the defect is due to a contradiction in the logic with the checkPreConditions method of BasicMessageConsumer_0_10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3542) Java client does not ack non-matching
messages when using client side selectors (CPP Broker)
Posted by "Keith Wall (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall resolved QPID-3542.
------------------------------
Resolution: Fixed
Assignee: Andrew MacBean (was: Keith Wall)
Patch applied.
> Java client does not ack non-matching messages when using client side selectors (CPP Broker)
> --------------------------------------------------------------------------------------------
>
> Key: QPID-3542
> URL: https://issues.apache.org/jira/browse/QPID-3542
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Client
> Affects Versions: 0.13
> Reporter: Andrew MacBean
> Assignee: Andrew MacBean
> Attachments: 0001-QPID-3542-Java-client-does-not-ack-non-matching-mess.patch
>
>
> For topic destinations when client side selectors are in-use, the Java client must ack all messages that do not match the JMS selector. Presently this does not happen and the messages remain un-ack'd on the CPP Broker.
> The defect does not manifest itself on the Java Broker as it uses server side selectors nor the non-0.10 code paths.
> Investigation has shown that the defect is due to a contradiction in the logic with the checkPreConditions method of BasicMessageConsumer_0_10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3542) Java client does not ack non-matching
messages when using client side selectors (CPP Broker)
Posted by "Andrew MacBean (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean reassigned QPID-3542:
------------------------------------
Assignee: Keith Wall (was: Andrew MacBean)
> Java client does not ack non-matching messages when using client side selectors (CPP Broker)
> --------------------------------------------------------------------------------------------
>
> Key: QPID-3542
> URL: https://issues.apache.org/jira/browse/QPID-3542
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Client
> Affects Versions: 0.13
> Reporter: Andrew MacBean
> Assignee: Keith Wall
> Attachments: 0001-QPID-3542-Java-client-does-not-ack-non-matching-mess.patch
>
>
> For topic destinations when client side selectors are in-use, the Java client must ack all messages that do not match the JMS selector. Presently this does not happen and the messages remain un-ack'd on the CPP Broker.
> The defect does not manifest itself on the Java Broker as it uses server side selectors nor the non-0.10 code paths.
> Investigation has shown that the defect is due to a contradiction in the logic with the checkPreConditions method of BasicMessageConsumer_0_10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3542) Java client does not ack non-matching
messages when using client side selectors (CPP Broker)
Posted by "Keith Wall (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall resolved QPID-3542.
------------------------------
Resolution: Fixed
Patch applied.
> Java client does not ack non-matching messages when using client side selectors (CPP Broker)
> --------------------------------------------------------------------------------------------
>
> Key: QPID-3542
> URL: https://issues.apache.org/jira/browse/QPID-3542
> Project: Qpid
> Issue Type: Sub-task
> Components: Java Client
> Affects Versions: 0.13
> Reporter: Andrew MacBean
> Assignee: Keith Wall
> Attachments: 0001-QPID-3542-Java-client-does-not-ack-non-matching-mess.patch, 0001-QPID-3542-ensure-session-complete-sent-for-filtered-.patch
>
>
> For topic destinations when client side selectors are in-use, the Java client must ack all messages that do not match the JMS selector. Presently this does not happen and the messages remain un-ack'd on the CPP Broker.
> The defect does not manifest itself on the Java Broker as it uses server side selectors nor the non-0.10 code paths.
> Investigation has shown that the defect is due to a contradiction in the logic with the checkPreConditions method of BasicMessageConsumer_0_10.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org