[jira] [Commented] (HIVE-5565) Limit Hive decimal type maximum precision and scale to 38

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-5565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13816895#comment-13816895 ] 

Hive QA commented on HIVE-5565:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12612730/HIVE-5565.patch

{color:red}ERROR:{color} -1 due to 20 failed/errored test(s), 4594 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_decimal_3
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_decimal_4
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_decimal_6
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_decimal_precision
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_decimal_udf
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_literal_decimal
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_serde_regex
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf7
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_invalid_cast_from_binary_1
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_invalid_cast_from_binary_2
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_invalid_cast_from_binary_3
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_invalid_cast_from_binary_4
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_invalid_cast_from_binary_5
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_invalid_cast_from_binary_6
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_wrong_column_type
org.apache.hadoop.hive.ql.exec.TestFunctionRegistry.testCommonClass
org.apache.hadoop.hive.ql.exec.TestFunctionRegistry.testCommonClassComparison
org.apache.hadoop.hive.ql.exec.TestFunctionRegistry.testCommonClassUnionAll
org.apache.hadoop.hive.ql.io.orc.TestOrcFile.testReadFormat_0_11
org.apache.hadoop.hive.ql.io.orc.TestOrcFile.testUnionAndTimestamp
{noformat}

Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/191/testReport
Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/191/console

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests failed with: TestsFailedException: 20 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12612730

> Limit Hive decimal type maximum precision and scale to 38
> ---------------------------------------------------------
>
>                 Key: HIVE-5565
>                 URL: https://issues.apache.org/jira/browse/HIVE-5565
>             Project: Hive
>          Issue Type: Task
>          Components: Types
>    Affects Versions: 0.13.0
>            Reporter: Xuefu Zhang
>            Assignee: Xuefu Zhang
>             Fix For: 0.13.0
>
>         Attachments: HIVE-5565.patch
>
>
> With HIVE-3976, the maximum precision is set to 65, and maximum scale is to 30. After discussing with several folks in the community, it's determined that 38 as a maximum for both precision and scale are probably sufficient, in addition to the potential performance boost that might become possible to some implementation.
> This task is to make such a change. The change is expected to be trivial, but it may impact many test cases. The reason for a separate JIRA is that patch in HIVE-3976 is already in a good shape. Rather than destabilizing a bigger patch, a dedicate patch will facilitates both reviews.
> The wiki document will be updated shortly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)