[lucene-solr] branch reference_impl updated: #154 - Change SPI reload default.

[ma...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

markrmiller pushed a commit to branch reference_impl
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git


The following commit(s) were added to refs/heads/reference_impl by this push:
     new a745b3c  #154 - Change SPI reload default.
a745b3c is described below

commit a745b3c640ca3d98260bd98e78ae8ed4fc13fc70
Author: markrmiller@gmail.com <ma...@gmail.com>
AuthorDate: Tue Jul 14 14:33:31 2020 -0500

    #154 - Change SPI reload default.
---
 solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java | 2 +-
 solr/test-framework/src/java/org/apache/solr/SolrTestCase.java  | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java b/solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java
index ac170ae..6457275 100644
--- a/solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java
+++ b/solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java
@@ -238,7 +238,7 @@ public class SolrResourceLoader implements ResourceLoader, Closeable {
    * and before using this ResourceLoader.
    */
   synchronized void reloadLuceneSPI() {
-    if (Boolean.getBoolean("solr.skipReloadSPI")) {
+    if (!Boolean.getBoolean("solr.reloadSPI")) {
       return;
     }
 
diff --git a/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java b/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
index 6312e14..5c7070a 100644
--- a/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
+++ b/solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
@@ -187,7 +187,9 @@ public class SolrTestCase extends LuceneTestCase {
       // can make things quite slow
       System.setProperty("solr.disableJmxReporter", "true");
       System.setProperty("solr.skipCommitOnClose", "true");
-      System.setProperty("solr.skipReloadSPI", "true"); // can generate tons of URL garbage and can happen too often
+
+      // can generate tons of URL garbage and can happen too often, defaults to false now anyway
+      System.setProperty("solr.reloadSPI", "false");
 
       // nocommit - not used again yet
       System.setProperty("solr.OverseerStateUpdateDelay", "0");