You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Reiss (JIRA)" <ji...@apache.org> on 2010/05/11 19:02:51 UTC

[jira] Commented: (THRIFT-646) Erlang library is missing install target

    [ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866207#action_12866207 ] 

David Reiss commented on THRIFT-646:
------------------------------------

Anyone care if I commit this follow-up patch?

> Erlang library is missing install target
> ----------------------------------------
>
>                 Key: THRIFT-646
>                 URL: https://issues.apache.org/jira/browse/THRIFT-646
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.2
>            Reporter: Anthony Molinaro
>            Assignee: Anthony Molinaro
>             Fix For: 0.4
>
>         Attachments: erl.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>
>
> The lib/erl/Makefile current contains
> install: all
>     echo 'No install target, sorry.'
> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang.  This means if someone has multiple erlangs install it will use whichever it finds first.
> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
> The current lib/erl/Makefile should be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (THRIFT-646) Erlang library is missing install target

Posted by Eugene Letuchy <el...@facebook.com>.
Go for it. Though 
http://lists.gnu.org/archive/html/bug-autoconf/2010-05/msg00003.html is a little 
off-putting.
- Eugene

On 5/11/10 10:02 AM, David Reiss (JIRA) wrote:
>
>      [ https://issues.apache.org/jira/browse/THRIFT-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866207#action_12866207 ]
>
> David Reiss commented on THRIFT-646:
> ------------------------------------
>
> Anyone care if I commit this follow-up patch?
>
>> Erlang library is missing install target
>> ----------------------------------------
>>
>>                  Key: THRIFT-646
>>                  URL: https://issues.apache.org/jira/browse/THRIFT-646
>>              Project: Thrift
>>           Issue Type: Bug
>>     Affects Versions: 0.2
>>             Reporter: Anthony Molinaro
>>             Assignee: Anthony Molinaro
>>              Fix For: 0.4
>>
>>          Attachments: erl.patch, Makefile.am, v1-0001-THRIFT-646.-erlang-Misc-build-cleanups.patch
>>
>>
>> The lib/erl/Makefile current contains
>> install: all
>>      echo 'No install target, sorry.'
>> The attached Makefile.am includes both an install and uninstall target which places things into the correct erlang library directory for the installed erlang.  This means if someone has multiple erlangs install it will use whichever it finds first.
>> Also attached is the patch to configrue.ac which causes automake to recognize the Makefile.am.
>> The current lib/erl/Makefile should be removed.
>