You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/06/18 19:16:05 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #7729:
Bugfix: bump SQLAlchemy to 1.3.5
villebro opened a new pull request #7729: Bugfix: bump SQLAlchemy to 1.3.5
URL: https://github.com/apache/incubator-superset/pull/7729
### CATEGORY
- [x] Bug Fix
### SUMMARY
A question on StackOverflow ( https://stackoverflow.com/questions/56579055/how-to-write-a-valid-custom-sql-metric-in-apache-superset-i-need-to-write-a-met ) helped identify a bug in `SQLAlchemy<=1.3.4`, which was quickly addressed ( https://github.com/sqlalchemy/sqlalchemy/issues/4730 ). The change can be seen in the changelog for 1.3.5: https://github.com/sqlalchemy/sqlalchemy/blame/master/doc/build/changelog/changelog_13.rst#L114-L130
### BEFORE
<img width="1230" alt="Screenshot 2019-06-18 at 21 59 57" src="https://user-images.githubusercontent.com/33317356/59712614-3fde9b80-9216-11e9-8b17-48cc99df764d.png">
<img width="872" alt="Screenshot 2019-06-18 at 22 04 55" src="https://user-images.githubusercontent.com/33317356/59712637-48cf6d00-9216-11e9-9f43-036ce87adb03.png">
### AFTER
<img width="1231" alt="Screenshot 2019-06-18 at 22 03 08" src="https://user-images.githubusercontent.com/33317356/59712711-6ac8ef80-9216-11e9-9088-d53c55226b4e.png">
<img width="873" alt="Screenshot 2019-06-18 at 22 03 44" src="https://user-images.githubusercontent.com/33317356/59712724-6f8da380-9216-11e9-8b0e-8e9d4ff9ea42.png">
### TEST PLAN
Tested locally. Decided against new tests, as relevant tests were added to SQLAlchemy.
### ADDITIONAL INFORMATION
- [x] Has associated issue: #7712
### REVIEWERS
@betodealmeida @john-bodley @mistercrunch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org