You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/12/30 13:01:38 UTC
[GitHub] [druid] kaijianding opened a new pull request #10722: fix message gap not reported when thrownAway
kaijianding opened a new pull request #10722:
URL: https://github.com/apache/druid/pull/10722
When useEarliestOffset =true , we want to know the message gap when reading from the earliest Kafka offset while the out-dated records are being thrown away, we can use the message gap to estimate how much time left coming to the latest offset
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on a change in pull request #10722: fix message gap not reported when thrownAway
Posted by GitBox <gi...@apache.org>.
gianm commented on a change in pull request #10722:
URL: https://github.com/apache/druid/pull/10722#discussion_r553707999
##########
File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorPlumber.java
##########
@@ -153,6 +153,7 @@ public IncrementalIndexAddResult add(InputRow row, Supplier<Committer> committer
{
final SegmentIdWithShardSpec identifier = getSegmentIdentifier(row.getTimestampFromEpoch());
if (identifier == null) {
+ metrics.reportMessageMaxTimestamp(row.getTimestampFromEpoch());
Review comment:
@kaijianding Did you mean this to help with the Kafka indexing service mechanism? If so, this isn't the right file; it's only used by `AppenderatorPlumberSchool`, but Kafka indexing doesn't use that. I think AppenderatorImpl would be the right place to add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org