You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/21 14:29:42 UTC

[GitHub] [tvm] jchia edited a comment on pull request #7320: Made tensorflow IsNan actually work

jchia edited a comment on pull request #7320:
URL: https://github.com/apache/tvm/pull/7320#issuecomment-764676518


   > Thanks for the patch. Can you please add a test case for `IsNan`, to make sure it doesn't regress in future?
   
   I'm not familiar with the code base, but I think the test will be similar to `test_forward_isinf()` in `tests/python/frontend/tensorflow/test_forward.py`. Is that the right approach? I'm not sure how to run the test properly on my dev machine, though and it keeps failing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org