[GitHub] [arrow-datafusion] crepererum commented on pull request #6708: Minor: `derive(Debug)` for `Expr`

["crepererum (via GitHub)" <gi...@apache.org>]

crepererum commented on PR #6708:
URL: https://github.com/apache/arrow-datafusion/pull/6708#issuecomment-1598916371

   So I had a quick look at the outputs: I think the changes to the sqllogictests (e.g. `on=[(Column { name: "t1_id", index: 0 }, Column { name: "t2_id", index: 0 })]` => `on=[(t1_id@0, t2_id@0)]`) are desired. The new output is way easier to read and matches the formatting that we use for other plan formatting. Please update the tests accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org