[jira] [Commented] (HIVE-18738) LLAP IO ACID - includes handling is broken

["Sergey Shelukhin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-18738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368092#comment-16368092 ] 

Sergey Shelukhin commented on HIVE-18738:
-----------------------------------------

A WIP patch that clarifies the semantics of various include variables and fixes the double-ACID-ifying and other incorrect treatment of them in the IO elevator.

It already works if one makes changes to not exclude the ACID ROW column from includes and removes the added nested column magic from ORC genIncludedColumns; however it then reads all ACID struct nested columns, even though it might only need a subset.
Excluding the ROW column and including its subset via nested column magic makes it read only a subset of the ROW struct that it needs, but everything after the reader (e.g. decoder) is still set up incorrectly; after treereaderfactory is fixed, I suspect the next thing to break will be the ACID wrapper that blindly puts CVs from elevator into VRB that is passed to the thing the applies deletes. That might not work so well without always having the whole ROW struct (payload will be null).

Also all the debug logging needs to be undone later.


> LLAP IO ACID - includes handling is broken
> ------------------------------------------
>
>                 Key: HIVE-18738
>                 URL: https://issues.apache.org/jira/browse/HIVE-18738
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Deepesh Khandelwal
>            Assignee: Sergey Shelukhin
>            Priority: Major
>         Attachments: HIVE-18738.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)