You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/04/24 04:27:22 UTC
[GitHub] [dubbo-go] wujincheng2333 opened a new pull request, #1857: fix getRandomPort
wujincheng2333 opened a new pull request, #1857:
URL: https://github.com/apache/dubbo-go/pull/1857
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
Fixes #1850
**You should pay attention to items below to ensure your pr passes our ci test**
We do not merge pr with ci tests failed
- [ ] All ut passed (run 'go test ./...' in project root)
- [ ] After go-fmt ed , run 'go fmt project' using goland.
- [ ] Golangci-lint passed, run 'sudo golangci-lint run' in project root.
- [ ] After import formatted, (using [imports-formatter](https://github.com/dubbogo/tools#5-how-to-get-imports-formatter) to run 'imports-formatter .' in project root, to format your import blocks, mentioned in [CONTRIBUTING.md](https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md) above)
- [ ] Your new-created file needs to have [apache license](https://raw.githubusercontent.com/dubbogo/resources/master/tools/license/license.txt) at the top, like other existed file does.
- [ ] All integration test passed. You can run integration test locally (with docker env). Clone our [dubbo-go-samples](https://github.com/apache/dubbo-go-samples) project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] wujincheng2333 commented on a diff in pull request #1857: fix getRandomPort
Posted by GitBox <gi...@apache.org>.
wujincheng2333 commented on code in PR #1857:
URL: https://github.com/apache/dubbo-go/pull/1857#discussion_r862469728
##########
config/service_config.go:
##########
@@ -247,7 +253,17 @@ func (s *ServiceConfig) Export() error {
if len(proto.Port) == 0 {
port = nextPort.Value.(string)
nextPort = nextPort.Next()
+ }else{
Review Comment:
> 这代码显然没有 gofmt 处理过
是的，不好意思，我以为你们会修改代码风格之类的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] wujincheng2333 closed pull request #1857: fix getRandomPort
Posted by GitBox <gi...@apache.org>.
wujincheng2333 closed pull request #1857: fix getRandomPort
URL: https://github.com/apache/dubbo-go/pull/1857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] wujincheng2333 commented on pull request #1857: fix getRandomPort
Posted by GitBox <gi...@apache.org>.
wujincheng2333 commented on PR #1857:
URL: https://github.com/apache/dubbo-go/pull/1857#issuecomment-1112790037
> @wujincheng2333 修改base分支到3.0
已修改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1857: fix getRandomPort
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on PR #1857:
URL: https://github.com/apache/dubbo-go/pull/1857#issuecomment-1112191136
@wujincheng2333 修改base分支到3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a diff in pull request #1857: fix getRandomPort
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on code in PR #1857:
URL: https://github.com/apache/dubbo-go/pull/1857#discussion_r862337600
##########
config/service_config.go:
##########
@@ -247,7 +253,17 @@ func (s *ServiceConfig) Export() error {
if len(proto.Port) == 0 {
port = nextPort.Value.(string)
nextPort = nextPort.Next()
+ }else{
Review Comment:
这代码显然没有 gofmt 处理过
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org