You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2021/12/22 09:56:49 UTC
[kudu-CR] [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18112
Change subject: [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
......................................................................
[tools] Fix schema version incorrctly set to 0 bug after rebuilding master
Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/master_rebuilder.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
6 files changed, 89 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/18112/1
--
To view, visit http://gerrit.cloudera.org:8080/18112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
Gerrit-Change-Number: 18112
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18112 )
Change subject: [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
......................................................................
[tools] Fix schema version incorrctly set to 0 bug after rebuilding master
If we rebuild master for tables with 0 schema version, we may get
errors like following on master:
TS xxx (xxx:xxx) has reported a schema version greater than the current one for tablet xxx (table xxx [id=xxx]). Expected version 0 got n (corruption)
...
TS xxx (xxx:xxx): alter failed for tablet xxx (table xxx [id=xxx]),no further retry: Invalid argument: Tablet has a newer schema
or
TS xxx (xxx:xxx): alter failed for tablet xxx (table xxx [id=xxx]),no further retry: Corruption: got a different schema for the same version number
Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
Reviewed-on: http://gerrit.cloudera.org:8080/18112
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/master_rebuilder.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
7 files changed, 95 insertions(+), 18 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
Gerrit-Change-Number: 18112
Gerrit-PatchSet: 6
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18112 )
Change subject: [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
Gerrit-Change-Number: 18112
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 28 Dec 2021 19:14:44 +0000
Gerrit-HasComments: No
[kudu-CR] [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18112 )
Change subject: [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc
File src/kudu/tools/master_rebuilder.cc:
http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc@59
PS3, Line 59: "The minimal table schema version. When tserver "
nit: maybe be more specific about what's going on here:
"The table schema version assigned to tables if one cannot be determined automatically. When the tablet server version is < 1.6, a viable value can be determined manually using 'kudu pbc dump tablet-meta/<tablet-id>' on each server and taking the max value found across all tablets. In tablet server versions >= 1.6, Kudu will determine the proper value for each tablet automatically."
Also, does this value need to be exact? Or is it viable to set an arbitrarily high value for this?
http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc@59
PS3, Line 59: min
nit: maybe call this "default_schema_version"?
http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc@60
PS3, Line 60: 1.6
Should this be 1.16?
--
To view, visit http://gerrit.cloudera.org:8080/18112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
Gerrit-Change-Number: 18112
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 23 Dec 2021 22:11:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18112 )
Change subject: [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc
File src/kudu/tools/master_rebuilder.cc:
http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc@59
PS3, Line 59: 0, "The table schema version assigned to tables
> nit: maybe be more specific about what's going on here:
It's viable to set an arbitrarily high value.
http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc@59
PS3, Line 59: def
> nit: maybe call this "default_schema_version"?
Done
http://gerrit.cloudera.org:8080/#/c/18112/3/src/kudu/tools/master_rebuilder.cc@60
PS3, Line 60: det
> Should this be 1.16?
Yes, 1.16..
--
To view, visit http://gerrit.cloudera.org:8080/18112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
Gerrit-Change-Number: 18112
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 24 Dec 2021 06:35:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18112
to look at the new patch set (#4).
Change subject: [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
......................................................................
[tools] Fix schema version incorrctly set to 0 bug after rebuilding master
If we rebuild master for tables with 0 schema version, we may get
errors like following on master:
TS xxx (xxx:xxx) has reported a schema version greater than the current one for tablet xxx (table xxx [id=xxx]). Expected version 0 got n (corruption)
...
TS xxx (xxx:xxx): alter failed for tablet xxx (table xxx [id=xxx]),no further retry: Invalid argument: Tablet has a newer schema
or
TS xxx (xxx:xxx): alter failed for tablet xxx (table xxx [id=xxx]),no further retry: Corruption: got a different schema for the same version number
Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/master_rebuilder.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
6 files changed, 92 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/18112/4
--
To view, visit http://gerrit.cloudera.org:8080/18112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
Gerrit-Change-Number: 18112
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18112
to look at the new patch set (#5).
Change subject: [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
......................................................................
[tools] Fix schema version incorrctly set to 0 bug after rebuilding master
If we rebuild master for tables with 0 schema version, we may get
errors like following on master:
TS xxx (xxx:xxx) has reported a schema version greater than the current one for tablet xxx (table xxx [id=xxx]). Expected version 0 got n (corruption)
...
TS xxx (xxx:xxx): alter failed for tablet xxx (table xxx [id=xxx]),no further retry: Invalid argument: Tablet has a newer schema
or
TS xxx (xxx:xxx): alter failed for tablet xxx (table xxx [id=xxx]),no further retry: Corruption: got a different schema for the same version number
Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/master_rebuilder.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
7 files changed, 95 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/18112/5
--
To view, visit http://gerrit.cloudera.org:8080/18112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
Gerrit-Change-Number: 18112
Gerrit-PatchSet: 5
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18112
to look at the new patch set (#2).
Change subject: [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
......................................................................
[tools] Fix schema version incorrctly set to 0 bug after rebuilding master
Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/master_rebuilder.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
6 files changed, 90 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/18112/2
--
To view, visit http://gerrit.cloudera.org:8080/18112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
Gerrit-Change-Number: 18112
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18112
to look at the new patch set (#3).
Change subject: [tools] Fix schema version incorrctly set to 0 bug after rebuilding master
......................................................................
[tools] Fix schema version incorrctly set to 0 bug after rebuilding master
If we rebuild master for tables with 0 schema version, we may get
errors like following on master:
TS xxx (xxx:xxx) has reported a schema version greater than the current one for tablet xxx (table xxx [id=xxx]). Expected version 0 got n (corruption)
...
TS xxx (xxx:xxx): alter failed for tablet xxx (table xxx [id=xxx]),no further retry: Invalid argument: Tablet has a newer schema
or
TS xxx (xxx:xxx): alter failed for tablet xxx (table xxx [id=xxx]),no further retry: Corruption: got a different schema for the same version number
Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
---
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/master_rebuilder.cc
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
6 files changed, 90 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/18112/3
--
To view, visit http://gerrit.cloudera.org:8080/18112
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf8b7c0c45bcc6160f6eabf977968de5a88ef5c7
Gerrit-Change-Number: 18112
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)