[GitHub] [helix] dasahcc commented on a change in pull request #974: Enforce result check for data accessors batch get calls to prevent partial batch read.

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #974:
URL: https://github.com/apache/helix/pull/974#discussion_r420989738



##########
File path: helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
##########
@@ -701,7 +701,7 @@ private void syncSessionToController(HelixManager manager) {
       }
     }
 
-    List<Message> newMessages = accessor.getProperty(keys);
+    List<Message> newMessages = accessor.getProperty(keys, true);

Review comment:
       This is not a good idea. If we throws exception here, then there is no event to trigger message read. Then it could only relies on @mgao0 's periodical message refresh. But if user does not set this up?
   
   Do not throw exception at least can read some message back and process them. Also when ST done with these partial messages, delete message operation can trigger another round of read. I know relies on this logic is not robust. But at least, it is not worse scenario than throw exception here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org