You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Neal Richardson (Jira)" <ji...@apache.org> on 2021/05/08 00:45:00 UTC
[jira] [Commented] (ARROW-12696) [R] Improve testing of error
messages converted to warnings
[ https://issues.apache.org/jira/browse/ARROW-12696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17341085#comment-17341085 ]
Neal Richardson commented on ARROW-12696:
-----------------------------------------
To your questions:
Whether we intend to keep abandon_ship() working as it does even after dplyr support in the package becomes more comprehensive: _yes, I'd say so, at least for the foreseeable future there will be a long tail of features we haven't implemented in Arrow._
Whether we should modify abandon_ship() to incorporate the original error message into the warning it gives instead of throwing a generic and likely less helpful warning message: _maybe, though this is only going to be informative for the functions we've implemented--base R functions called on Arrow Expressions will probably error with unhelpful messages in many cases._
I will try to take this on Monday, depending on how productive my day is, otherwise I'll toss it back to you.
> [R] Improve testing of error messages converted to warnings
> -----------------------------------------------------------
>
> Key: ARROW-12696
> URL: https://issues.apache.org/jira/browse/ARROW-12696
> Project: Apache Arrow
> Issue Type: Improvement
> Components: R
> Affects Versions: 4.0.0
> Reporter: Ian Cook
> Assignee: Ian Cook
> Priority: Major
>
> The {{abandon_ship()}} function catches errors that occur because of unsupported functions/arguments and issues warnings in place of the of errors. These warnings do not use the same messages as the errors.
> There are many dplyr tests that use {{expect_warning()}} to effectively check that an error occurred before it was converted to a warning. These tests do not assert the expected error message, because that message is lost in the conversion to a warning.
> Consider ways to improve these tests to enable them to assert the expected error messages.
> Alternatively, consider:
> * Whether we intend to keep {{abandon_ship()}} working as it does even after dplyr support in the package becomes more comprehensive
> * Whether we should modify {{abandon_ship()}} to incorporate the original error message into the warning it gives instead of throwing a generic and likely less helpful warning message
> See the related discussion at [https://github.com/apache/arrow/pull/10190/files#r628314240]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)