You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/11 23:08:46 UTC
[GitHub] [helix] zhangmeng916 opened a new pull request #887: update cache
functions
zhangmeng916 opened a new pull request #887: update cache functions
URL: https://github.com/apache/helix/pull/887
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
(#850 )
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
This PR update some cache functions, including some participant cache changes and customized view cache change. The main reason for participant cache change is that we do not want to access ZK outside of resource data provider, because that would break the assumption of some of our tests. For customized view cache, the remove function is added for refresh purpose.
### Tests
- [X] The following is the result of the "mvn test" command on the appropriate module:
[INFO] Tests run: 909, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3,438.097 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 909, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
### Commits
- [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [X] My diff has been formatted using helix-style.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on issue #887: update cache
functions for customized view aggregation
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on issue #887: update cache functions for customized view aggregation
URL: https://github.com/apache/helix/pull/887#issuecomment-598036570
This PR is ready to merge, approved by @jiajunwang
Final commit message:
"Update some cache functions for customized view aggregation"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] dasahcc merged pull request #887: update cache functions
for customized view aggregation
Posted by GitBox <gi...@apache.org>.
dasahcc merged pull request #887: update cache functions for customized view aggregation
URL: https://github.com/apache/helix/pull/887
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org