You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/18 02:25:57 UTC
[GitHub] [hudi] danny0405 opened a new pull request, #5617: [HUDI-4114] Remove the unnecessary fs view sync for BaseWriteClient#i…
danny0405 opened a new pull request, #5617:
URL: https://github.com/apache/hudi/pull/5617
…nitTable
No need to #sync actively because the table instance is instantiated freshly,
its view manager has empty fiew instantces, the fs view would be synced lazily when
is it requested.
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #5617: [HUDI-4114] Remove the unnecessary fs view sync for BaseWriteClient#i…
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #5617:
URL: https://github.com/apache/hudi/pull/5617#issuecomment-1131196973
> @danny0405 : unless it is a hot fix, or some test related changes, can we not merge it in w/o getting a stamp from someone. It is a good practice to follow as to not miss out anything.
Oops, i'm sorry, would follow that in following PRs.
I did ping you on Slack but no response yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #5617: [HUDI-4114] Remove the unnecessary fs view sync for BaseWriteClient#i…
Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #5617:
URL: https://github.com/apache/hudi/pull/5617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5617: [HUDI-4114] Remove the unnecessary fs view sync for BaseWriteClient#i…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5617:
URL: https://github.com/apache/hudi/pull/5617#issuecomment-1129502253
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5608887388d04850d78a0fe322eb6130f269da7c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5608887388d04850d78a0fe322eb6130f269da7c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5608887388d04850d78a0fe322eb6130f269da7c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5617: [HUDI-4114] Remove the unnecessary fs view sync for BaseWriteClient#i…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5617:
URL: https://github.com/apache/hudi/pull/5617#issuecomment-1129659238
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5608887388d04850d78a0fe322eb6130f269da7c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8727",
"triggerID" : "5608887388d04850d78a0fe322eb6130f269da7c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5608887388d04850d78a0fe322eb6130f269da7c Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8727)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5617: [HUDI-4114] Remove the unnecessary fs view sync for BaseWriteClient#i…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5617:
URL: https://github.com/apache/hudi/pull/5617#issuecomment-1129504115
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5608887388d04850d78a0fe322eb6130f269da7c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8727",
"triggerID" : "5608887388d04850d78a0fe322eb6130f269da7c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5608887388d04850d78a0fe322eb6130f269da7c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8727)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #5617: [HUDI-4114] Remove the unnecessary fs view sync for BaseWriteClient#i…
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on code in PR #5617:
URL: https://github.com/apache/hudi/pull/5617#discussion_r876571323
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1466,8 +1466,6 @@ protected final HoodieTable initTable(WriteOperationType operationType, Option<S
// Validate table properties
metaClient.validateTableProperties(config.getProps());
- // Make sure that FS View is in sync
- table.getHoodieView().sync();
Review Comment:
@alexeykudinkin : I see you have added this with https://github.com/apache/hudi/pull/4739 Do you happened to know the reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #5617: [HUDI-4114] Remove the unnecessary fs view sync for BaseWriteClient#i…
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #5617:
URL: https://github.com/apache/hudi/pull/5617#issuecomment-1131172942
@danny0405 : unless it is a hot fix, or some test related changes, can we not merge it in w/o getting a stamp from someone.
It is a good practice to follow as to not miss out anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #5617: [HUDI-4114] Remove the unnecessary fs view sync for BaseWriteClient#i…
Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on code in PR #5617:
URL: https://github.com/apache/hudi/pull/5617#discussion_r877295801
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1466,8 +1466,6 @@ protected final HoodieTable initTable(WriteOperationType operationType, Option<S
// Validate table properties
metaClient.validateTableProperties(config.getProps());
- // Make sure that FS View is in sync
- table.getHoodieView().sync();
Review Comment:
This has been carried over from the Spark client
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org