Re: Review Request: HBASE-2579. Add atomic checkAndDelete support

[st...@duboce.net]

> On 2010-05-25 12:32:28, Todd Lipcon wrote:
> > Looks pretty good. The one thing I don't like is that checkAndMutate takes a Writable, and then downcasts based on instanceof. Can we extract a common interface between Put and Delete? maybe something like RowMutation or RowOperation, which would have getRowLock and a "performMutation()" or something? What do you guys think?
> 
> Ryan Rawson wrote:
>     I think we should address that in a different JIRA, just because its more of an API design.  This is one more API endpoint and that is more of a refactor.
> 
> Todd Lipcon wrote:
>     Fair enough

So, is this ready for commit? (we can address Todd comments on commit).  I can make an issue for common interface across Delete/Put.


- stack


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/84/#review54
-----------------------------------------------------------


On 2010-05-25 12:22:03, Todd Lipcon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/84/
> -----------------------------------------------------------
> 
> (Updated 2010-05-25 12:22:03)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Submitting to RB on behalf of Michael Dalton
> 
> 
> This addresses bug HBASE-2579.
>     http://issues.apache.org/jira/browse/HBASE-2579
> 
> 
> Diffs
> -----
> 
>   trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java 946565 
>   trunk/src/main/java/org/apache/hadoop/hbase/client/HTableInterface.java 946565 
>   trunk/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 946565 
>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 946565 
>   trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 946565 
>   trunk/src/main/java/org/apache/hadoop/hbase/rest/client/RemoteHTable.java 946565 
>   trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 946565 
> 
> Diff: http://review.cloudera.org/r/84/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Todd
> 
>