[GitHub] cordova-blackberry pull request: CB-7186 --no-signing will be igno...

[dylin <gi...@git.apache.org>]

Github user dylin commented on a diff in the pull request:

    https://github.com/apache/cordova-blackberry/pull/169#discussion_r15298452
  
    --- Diff: bin/templates/project/cordova/lib/cmdline.js ---
    @@ -30,7 +30,8 @@ command
         .option('-p, --params <params JSON file>', 'Specifies additional parameters to pass to downstream tools.')
         .option('--appdesc <filepath>', 'Optionally specifies the path to the bar descriptor file (bar-descriptor.xml). For internal use only.')
         .option('-v, --verbose', 'Turn on verbose messages')
    -    .option('-l, --loglevel <loglevel>', 'set the logging level (error, warn, verbose)');
    +    .option('-l, --loglevel <loglevel>', 'set the logging level (error, warn, verbose)')
    +    .option('--signing', 'if signing the app');
    --- End diff --
    
    cmdline.js not a command parser for end user, and end user won't see --signing in help message. cmdline.js parses arguments to packager, which inherits ww 1.0 packager.  and --signing is not a real argument to pass to packager, it's just a flag used by package-validate.js.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---