You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/22 09:54:39 UTC

[GitHub] [flink] TsReaper opened a new pull request #9197: [FLINK-13075][table-planner-blink] Project pushdown rule shouldn't require the TableSource return a modified schema in blink planner

TsReaper opened a new pull request #9197: [FLINK-13075][table-planner-blink] Project pushdown rule shouldn't require the TableSource return a modified schema in blink planner
URL: https://github.com/apache/flink/pull/9197
 
 
   ## What is the purpose of the change
   
   As the javadoc of `org.apache.flink.table.sources.ProjectableTableSource#projectFields` said, the table schema of the `TableSource` copy must not be modified by this method. However, `PushProjectIntoTableSourceScanRule` in blink planner requires the returning a table source with the modified table schema. This conflict with the javadoc and result in the `TableSource` works for flink planner can't work for blink planner.
   
   This PR fixes `PushProjectIntoTableSourceScanRule` and related class to make it work for blink planner.
   
   ## Brief change log
   
    - Fix `PushProjectIntoTableSourceScanRule` so that the schema of the newly created table source is the same with the original one.
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as `TableSourceItCase`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services