You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by malur <gi...@git.apache.org> on 2016/01/16 04:17:10 UTC

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

GitHub user malur opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/644

    [ZEPPELIN-576] Support Apache Drill Interpreter

    ### What is this PR for?
    Supports Apache Drill Interpreter
    
    ### What type of PR is it?
    Improvement, Feature
    
    ### Todos
    * [ ] - Documentation
    
    ### Is there a relevant Jira issue?
    Yes. ZEPPELIN-576
    
    ### How should this be tested?
    Choose a new Interpreter and provide the required details, necessary to connect to a running Apache Drill Instance. After which you can start firing Queries
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    **No**
    
    * Is there breaking changes for older versions?
    **No**
    
    * Does this needs documentation?
    **Yes**

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/walmart/incubator-zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/644.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #644
    
----
commit abd99d1f3f27cec5bbc4e855043c757765032a62
Author: Ramu Malur <ra...@walmart.com>
Date:   2015-12-09T03:26:46Z

    Merge remote-tracking branch 'apache/master'

commit 8e47a8693ba5f193892b8e3135bee254d3012e11
Author: Ramu Malur <ra...@walmart.com>
Date:   2015-12-09T10:51:52Z

    Initial Version of Drill Interpreter

commit dbf464324cf1bed84d2e335017c16fff1c1666b9
Author: Ramu Malur <ra...@walmart.com>
Date:   2015-12-09T10:58:00Z

    Fixed Check style Error

commit 100c59f914d9caaa5aff7d3f6c946392c63a4871
Author: Ramu Malur <ra...@walmart.com>
Date:   2015-12-17T09:40:57Z

    Merge remote-tracking branch 'apache/master'

commit 485515954b5ecef96e13686d3fe6633405d7d375
Author: Ramu Malur <ra...@walmart.com>
Date:   2015-12-17T09:41:10Z

    Added Unit Tests

commit a16915e0e46c9a8636b026e2867dc012f26b6501
Author: Ramu Malur <ra...@walmart.com>
Date:   2015-12-21T13:38:33Z

    Merge remote-tracking branch 'apache/master'

commit cebc38c83f68e8d868ca11974a82cc6cb3bc08ab
Author: Ramu Malur <ra...@walmart.com>
Date:   2015-12-28T06:15:40Z

    Merge remote-tracking branch 'apache/master'
    
    # Conflicts:
    #	pom.xml

commit 5f81b2e048143d496179d7dfe88b641087f872b3
Author: Ramu Malur <ra...@walmart.com>
Date:   2015-12-28T08:56:27Z

    Added support for maxResult

commit 30dfaf7d208d11603025dd81f9b0425cd8d51d23
Author: Ramu Malur <ra...@walmart.com>
Date:   2016-01-04T08:44:26Z

    Merge remote-tracking branch 'apache/master'
    
    # Conflicts:
    #	conf/zeppelin-site.xml.template

commit c0bcf1cccf5c8376c4b95cfef73c7a54fb39b2e6
Author: Ramu Malur <ra...@walmart.com>
Date:   2016-01-04T08:46:26Z

    Formatted zeppelin-site.xml.template properly

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by malur <gi...@git.apache.org>.
Github user malur commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-184131164
  
    Cool.
    Meanwhile I have added documentation around using Drill with JDBC Interpreter via PR #718


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by tmx11 <gi...@git.apache.org>.
Github user tmx11 commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-178251195
  
    Are you using the psql or hive interpreter for this to work?
    
    Also presumably we need to copy in the drill-jdbc-all-1.1.0.jar or drill-jdbc-1.1.0.jar into the classpath.
    
    Putting the all-jar under zeppelin/lib means the daemon can't start.
    
    If only the other one is under lib you get commons-lang3 errors but when putting this under lib also seems to still not find.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by malur <gi...@git.apache.org>.
Github user malur commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-172320196
  
    @vgmartinez, that would be right approach. I will wait for the merge to happen.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-172320004
  
    Hi @malur,
    I think it's a good idea to wait to be done merge the Generic JDBC and work on that to add support for everything related to JDBC connectors. What do you think...?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by malur <gi...@git.apache.org>.
Github user malur commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-172318193
  
    I looked into the Generic JDBC approach. Looks good.
    So, 
    * We need to use the Generic JDBC Interpreter code & extend that to provide specific properties of Drill?
    * I should wait for the pull request #361 to be merged to work on this?
    
    Drill JDBC driver is Apache 2.0 License. Do we still need to add entry in Licenses folder? I can add it. Please confirm.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by malur <gi...@git.apache.org>.
Github user malur commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-182393653
  
    Agreed.
    I had this in my list of TODO. Will take some time out over weekend & try to add this information.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-172279034
  
    Previously we have a contribution for Drill interpreter (PR #110) and it seems we have concluded that it should be on top of a generic JDBC interpreter - what you think about that approach?
    
    In any case, the use of `org.apache.drill.exec` would need to be added to licenses, could you look into that?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-181716616
  
    @tmx11 Hi, could you please those jars under `/interpreters/jdbc/`? I think this would be more general position to use that interpreter. If it still doesn't work, tell me again. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-174817516
  
    @malur Thanks for positive answer. And could you please close this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-182452023
  
    @smartinsightsfromdata @malur I also have a plan to enable customization for specific jdbc driver, for example, completers and dedicated word and so on. Jdbc interpreter will get better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by malur <gi...@git.apache.org>.
Github user malur closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/644


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-173119037
  
    @malur Sorry for late reply. In my opinion, JDBCInterpreter can cover this feature. If it's not, please let me know. Otherwise, how about updating docs for using Drill with JDBC? https://github.com/apache/incubator-zeppelin/blob/master/docs/interpreter/hive.md will help you improve docs because the configuration of JDBCInterpreter is based on HiveInterpreter. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by malur <gi...@git.apache.org>.
Github user malur commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-175933833
  
    Closing this PR, as generic JDBC provides the needed functionality.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by malur <gi...@git.apache.org>.
Github user malur commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-173449722
  
    @jongyoul Sure. I will check the latest code with Drill & Update docs, if needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [ZEPPELIN-576] Support Apache Dri...

Posted by smartinsightsfromdata <gi...@git.apache.org>.
Github user smartinsightsfromdata commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/644#issuecomment-182387053
  
    @jongyoul @malur  I think the relevance of Apache Drill deserves at the very least a document with a dedicated set of instructions on how to configure a Drill interpreter (i.e. a mini-tutorial).  
    
    At the moment this is missing but it would be great to have it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---