You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2021/03/23 12:41:47 UTC
[lucene] branch jira/LUCENE-9856-static-analysis updated (099184a
-> 278f23c)
This is an automated email from the ASF dual-hosted git repository.
rmuir pushed a change to branch jira/LUCENE-9856-static-analysis
in repository https://gitbox.apache.org/repos/asf/lucene.git.
from 099184a LUCENE-9856: override equals = must override hashcode too, @deprecated must @Deprecated too
add 078d007 LUCENE-9861: pull tuned vm options into a separate aspect. (#33)
new 1286ae2 Merge branch 'main' into jira/LUCENE-9856-static-analysis
new 278f23c LUCENE-9856: minor tweaks
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
build.gradle | 1 +
gradle/documentation/render-javadoc.gradle | 24 ++++++++++++----
gradle/generation/javacc.gradle | 10 +++----
.../turbocharge-jvm-opts.gradle} | 33 +++++++++++-----------
gradle/validation/ecj-lint.gradle | 3 --
.../apache/lucene/analysis/core/TestAnalyzers.java | 2 --
6 files changed, 40 insertions(+), 33 deletions(-)
copy gradle/{ide/intellij-idea.gradle => hacks/turbocharge-jvm-opts.gradle} (57%)
[lucene] 01/02: Merge branch 'main' into
jira/LUCENE-9856-static-analysis
Posted by rm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
rmuir pushed a commit to branch jira/LUCENE-9856-static-analysis
in repository https://gitbox.apache.org/repos/asf/lucene.git
commit 1286ae206819d44830dbb8c703a534f449f5d7b1
Merge: 099184a 078d007
Author: Robert Muir <rm...@apache.org>
AuthorDate: Tue Mar 23 07:51:40 2021 -0400
Merge branch 'main' into jira/LUCENE-9856-static-analysis
build.gradle | 1 +
gradle/documentation/render-javadoc.gradle | 24 +++++++++++++++-----
gradle/hacks/turbocharge-jvm-opts.gradle | 36 ++++++++++++++++++++++++++++++
gradle/validation/ecj-lint.gradle | 3 ---
4 files changed, 55 insertions(+), 9 deletions(-)
[lucene] 02/02: LUCENE-9856: minor tweaks
Posted by rm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
rmuir pushed a commit to branch jira/LUCENE-9856-static-analysis
in repository https://gitbox.apache.org/repos/asf/lucene.git
commit 278f23cc9a18787eeaf1e216c53670fd751b8f44
Author: Robert Muir <rm...@apache.org>
AuthorDate: Tue Mar 23 08:40:56 2021 -0400
LUCENE-9856: minor tweaks
TestAnalyzers tests doesn't need asserts, it had
SuppressWarnings("unused") the whole time, so we can revert the changes
since this is now respected.
Gradle has single quotes instead of double quotes, 30 minutes later :)
---
gradle/generation/javacc.gradle | 10 +++++-----
.../test/org/apache/lucene/analysis/core/TestAnalyzers.java | 2 --
2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/gradle/generation/javacc.gradle b/gradle/generation/javacc.gradle
index 1128a8d..c60c1ce 100644
--- a/gradle/generation/javacc.gradle
+++ b/gradle/generation/javacc.gradle
@@ -97,10 +97,10 @@ def commonCleanups = { FileTree generatedFiles ->
"// (setDebugStream omitted).")
text = text.replace(
"public class QueryParserTokenManager ",
- "@SuppressWarnings(\"unused\") public class QueryParserTokenManager ")
+ '@SuppressWarnings("unused") public class QueryParserTokenManager ')
text = text.replace(
"public class StandardSyntaxParserTokenManager ",
- "@SuppressWarnings(\"unused\") public class StandardSyntaxParserTokenManager ")
+ '@SuppressWarnings("unused") public class StandardSyntaxParserTokenManager ')
return text
})
}
@@ -131,7 +131,7 @@ configure(project(":lucene:queryparser")) {
"static final private LookaheadSuccess jj_ls =")
text = text.replace(
"public class QueryParser ",
- "@SuppressWarnings(\"unused\") public class QueryParser ")
+ '@SuppressWarnings("unused") public class QueryParser ')
return text
})
}
@@ -156,7 +156,7 @@ configure(project(":lucene:queryparser")) {
"new java.util.ArrayList<>")
text = text.replace(
"public class QueryParser ",
- "@SuppressWarnings(\"unused\") public class QueryParser ")
+ '@SuppressWarnings("unused") public class QueryParser ')
return text
})
}
@@ -235,7 +235,7 @@ configure(project(":lucene:queryparser")) {
"Collections.singletonList")
text = text.replace(
"public class StandardSyntaxParser ",
- "@SuppressWarnings(\"unused\") public class StandardSyntaxParser ")
+ '@SuppressWarnings("unused") public class StandardSyntaxParser ')
return text
})
}
diff --git a/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestAnalyzers.java b/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestAnalyzers.java
index c1161fa..31bb9f1 100644
--- a/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestAnalyzers.java
+++ b/lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestAnalyzers.java
@@ -109,9 +109,7 @@ public class TestAnalyzers extends BaseTokenStreamTestCase {
x = StandardTokenizer.HIRAGANA;
x = StandardTokenizer.KATAKANA;
x = StandardTokenizer.HANGUL;
- assert x >= 0;
String[] y = StandardTokenizer.TOKEN_TYPES;
- assert y != null;
}
private static class LowerCaseWhitespaceAnalyzer extends Analyzer {