You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/20 02:20:51 UTC

[GitHub] [arrow] liyafan82 opened a new pull request #8721: ARROW-10662: [Java] Avoid integer overflow for Json file reader

liyafan82 opened a new pull request #8721:
URL: https://github.com/apache/arrow/pull/8721


   For the current implementation, it uses int to represent the buffer size. However, the buffer can be larger than Integer.MAX_VALUE, which will lead to integer overflow and unexpected behaviors.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #8721: ARROW-10662: [Java] Avoid integer overflow for Json file reader

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8721:
URL: https://github.com/apache/arrow/pull/8721#issuecomment-730804419


   https://issues.apache.org/jira/browse/ARROW-10662


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] liyafan82 commented on pull request #8721: ARROW-10662: [Java] Avoid integer overflow for Json file reader

Posted by GitBox <gi...@apache.org>.
liyafan82 commented on pull request #8721:
URL: https://github.com/apache/arrow/pull/8721#issuecomment-732649665


   > LGTM.
   > 
   > One comment. I found a similar problem at [here](https://github.com/apache/arrow/blob/master/java/vector/src/main/java/org/apache/arrow/vector/DecimalVector.java#L150) while [this code](https://github.com/apache/arrow/blob/master/java/vector/src/main/java/org/apache/arrow/vector/Decimal256Vector.java#L150) takes care of it. Do we handle this in this PR?
   
   @kiszk Nice cath! Thank you so much.
   I have fixed it, as the change is not too big. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kiszk commented on pull request #8721: ARROW-10662: [Java] Avoid integer overflow for Json file reader

Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #8721:
URL: https://github.com/apache/arrow/pull/8721#issuecomment-732652523


   @liyafan82 Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kiszk commented on pull request #8721: ARROW-10662: [Java] Avoid integer overflow for Json file reader

Posted by GitBox <gi...@apache.org>.
kiszk commented on pull request #8721:
URL: https://github.com/apache/arrow/pull/8721#issuecomment-732373171


   LGTM.
   
   One comment. I found a similar problem at [here](https://github.com/apache/arrow/blob/master/java/vector/src/main/java/org/apache/arrow/vector/DecimalVector.java#L150) while [this code](https://github.com/apache/arrow/blob/master/java/vector/src/main/java/org/apache/arrow/vector/Decimal256Vector.java#L150) takes care of it. Do we handle this in this PR?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] liyafan82 closed pull request #8721: ARROW-10662: [Java] Avoid integer overflow for Json file reader

Posted by GitBox <gi...@apache.org>.
liyafan82 closed pull request #8721:
URL: https://github.com/apache/arrow/pull/8721


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org