You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2014/09/10 09:34:04 UTC
[GitHub] incubator-brooklyn pull request: apply back-off logic to utrace, w...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/158
apply back-off logic to utrace, will prevent requests for 60s after a failure
@sjcorbett noted in #156 that utrace lookups may be slowing down his startup. i could not replicate that; utrace lookups have negligible impact for me, and caching and timeouts are in operation, but in case offline mode / poor network was responsible, this prevents utrace from trying lookups for 60s after a failure. @sjcorbett does this help?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn utrace
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/158.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #158
----
commit 47178ae7fa97f7f4af7a3d9820354c8a2219a3a6
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2014-09-10T07:30:39Z
apply back-off logic to utrace, will prevent requests for 60s after a failure
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: apply back-off logic to utrace, w...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/158#issuecomment-55187616
Have reviewed second commit that just came through. Not certain if 3 seconds default timeout is too short, but don't have a better number to suggest. Merging.
@sjcorbett thank for pointer to `LocalhostExternalIpLoader`. The try-finally looks to be in the wrong place. It sets triedLocalExternalIp inside the for loop rather than after. Is that right?
https://github.com/apache/incubator-brooklyn/blob/master/core/src/main/java/brooklyn/location/geo/LocalhostExternalIpLoader.java#L139-156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: apply back-off logic to utrace, w...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/158#issuecomment-55186162
+1; change looks sensible. It's using a `static` for `LAST_FAILURE_UTC` so should fix the build problem. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: apply back-off logic to utrace, w...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/158#issuecomment-55186512
@sjcorbett as discussed i've implemented a simple short timeout if utrace blacklists and does not respond quickly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: apply back-off logic to utrace, w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: apply back-off logic to utrace, w...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/158#issuecomment-55099629
To explain a bit more, it would seem that I was affected by the things `UtraceHostGeoLookup` warns of: "you get blacklisted and requests may time out, or return none." Things are back to normal again, for now at least. I saw a lot of logging like this:
```
2014-09-09 16:41:56,775 DEBUG b.l.geo.UtraceHostGeoLookup [..]: Geo info lookup for 127.0.0.1/127.0.0.1 at http://xml.utrace.de/?query=86.185.34.72
...
2014-09-09 16:43:12,130 DEBUG b.l.geo.UtraceHostGeoLookup [..]: Geo info lookup for 127.0.0.1/127.0.0.1 failed: java.net.ConnectException: Operation timed out
```
The repeat minute and a half's delay encumbered Brooklyn significantly. A build with tests would never finish. The web console and REST API were unusable.
@ahgittin Your change looks fair. Longer term I think we want to load the data in the background like `LocalhostExternalIpLoader`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---