You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by st...@duboce.net on 2010/10/21 01:51:25 UTC
Review Request: hbase-2998 rolling-restart.sh shouldn't rely on zoo.cfg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1057/
-----------------------------------------------------------
Review request for hbase, Jean-Daniel Cryans and Jonathan Gray.
Summary
-------
Fix 'hbase zkcli' so it reads zk ensemble location from hbase config/zoo.cfg. This fixes rolling restart. Patch also includes fix so rolling restarts work on new master.
A src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java
Test for new TZMSA class.
M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java
Minor edit of javadoc.
A src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java
Tool to emit what ZooKeeperMain wants for a server argument.
M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
(isAbort): Added.
M src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java
Shutdown hook now needs to startup region shutdowns since new
master changed how shutdown sequence runs.
M src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
Don't do opens if server is stopped.
M src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
Minor formatting.
M bin/hbase
Run new ZKMSA tool to figure '-server host:port' to pass ZKM
M bin/hbase-daemon.sh
Make default wait be longer.
This addresses bug hbase-2998.
http://issues.apache.org/jira/browse/hbase-2998
Diffs
-----
trunk/bin/hbase 1025785
trunk/bin/hbase-daemon.sh 1025785
trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java 1025785
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1025785
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java 1025785
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java 1025785
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java 1025785
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java PRE-CREATION
trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java PRE-CREATION
Diff: http://review.cloudera.org/r/1057/diff
Testing
-------
Thanks,
stack
Re: Review Request: hbase-2998 rolling-restart.sh shouldn't rely on zoo.cfg
Posted by Jonathan Gray <jg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1057/#review1624
-----------------------------------------------------------
Ship it!
+1 after doing changes we discussed on IRC. Namely to make sure that the shutdown methods are idempotent and will work for stopping a backup master and that TestMasterFailover passes. Also some minor logging/comment changes around deleting root location.
- Jonathan
On 2010-10-22 11:59:16, stack wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1057/
> -----------------------------------------------------------
>
> (Updated 2010-10-22 11:59:16)
>
>
> Review request for hbase, Jean-Daniel Cryans and Jonathan Gray.
>
>
> Summary
> -------
>
> Fix 'hbase zkcli' so it reads zk ensemble location from hbase config/zoo.cfg. This fixes rolling restart. Patch also includes fix so rolling restarts work on new master.
>
> A src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java
> Test for new TZMSA class.
> M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java
> Minor edit of javadoc.
> A src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java
> Tool to emit what ZooKeeperMain wants for a server argument.
> M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> (isAbort): Added.
> M src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java
> Shutdown hook now needs to startup region shutdowns since new
> master changed how shutdown sequence runs.
> M src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
> Don't do opens if server is stopped.
> M src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
> Minor formatting.
> M bin/hbase
> Run new ZKMSA tool to figure '-server host:port' to pass ZKM
> M bin/hbase-daemon.sh
> Make default wait be longer.
>
>
> This addresses bug hbase-2998.
> http://issues.apache.org/jira/browse/hbase-2998
>
>
> Diffs
> -----
>
> trunk/bin/hbase 1026448
> trunk/bin/hbase-daemon.sh 1026448
> trunk/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 1026448
> trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java 1026448
> trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1026448
> trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1026448
> trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java 1026448
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java 1026448
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 1026448
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java 1026448
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 1026448
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java PRE-CREATION
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 1026448
> trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java PRE-CREATION
>
> Diff: http://review.cloudera.org/r/1057/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> stack
>
>
Re: Review Request: hbase-2998 rolling-restart.sh shouldn't rely on zoo.cfg
Posted by st...@duboce.net.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1057/
-----------------------------------------------------------
(Updated 2010-10-22 11:59:16.222128)
Review request for hbase, Jean-Daniel Cryans and Jonathan Gray.
Changes
-------
Here is updated patch. I've been testing it up on cluster. It fixes a bunch of things that rolling restart unearths...but there is still work to do. Meantime, this patch is growing beyond scope of the JIRA so would like to get it in in its current state.
Includes consideration of Jon's last review -- shutdown handler didn't need
amending afterall.
Includes refactor of master run because failure during processing of failover
was having the master exit but not go down -- rpc server was left up.
Summary
-------
Fix 'hbase zkcli' so it reads zk ensemble location from hbase config/zoo.cfg. This fixes rolling restart. Patch also includes fix so rolling restarts work on new master.
A src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java
Test for new TZMSA class.
M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java
Minor edit of javadoc.
A src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java
Tool to emit what ZooKeeperMain wants for a server argument.
M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
(isAbort): Added.
M src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java
Shutdown hook now needs to startup region shutdowns since new
master changed how shutdown sequence runs.
M src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
Don't do opens if server is stopped.
M src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
Minor formatting.
M bin/hbase
Run new ZKMSA tool to figure '-server host:port' to pass ZKM
M bin/hbase-daemon.sh
Make default wait be longer.
This addresses bug hbase-2998.
http://issues.apache.org/jira/browse/hbase-2998
Diffs (updated)
-----
trunk/bin/hbase 1026448
trunk/bin/hbase-daemon.sh 1026448
trunk/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 1026448
trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java 1026448
trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1026448
trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1026448
trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java 1026448
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java 1026448
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 1026448
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java 1026448
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 1026448
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java PRE-CREATION
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 1026448
trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java PRE-CREATION
Diff: http://review.cloudera.org/r/1057/diff
Testing
-------
Thanks,
stack
Re: Review Request: hbase-2998 rolling-restart.sh shouldn't rely on zoo.cfg
Posted by st...@duboce.net.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1057/
-----------------------------------------------------------
(Updated 2010-10-21 01:54:34.658192)
Review request for hbase, Jean-Daniel Cryans and Jonathan Gray.
Changes
-------
New patch includes faster assign of regions on startup (Uses async create/exists-set-watcher). Getting this working helps w/ rolling restart tests. Assign and watcher set for 2k regions runs fast now... used to be 90 seconds for 2k regions over 10 servers ... now its a matter of seconds for total bulk assign of all regions in just over a minute.
This patch is not yet ready. I need to test more.
Summary
-------
Fix 'hbase zkcli' so it reads zk ensemble location from hbase config/zoo.cfg. This fixes rolling restart. Patch also includes fix so rolling restarts work on new master.
A src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java
Test for new TZMSA class.
M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java
Minor edit of javadoc.
A src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java
Tool to emit what ZooKeeperMain wants for a server argument.
M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
(isAbort): Added.
M src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java
Shutdown hook now needs to startup region shutdowns since new
master changed how shutdown sequence runs.
M src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
Don't do opens if server is stopped.
M src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
Minor formatting.
M bin/hbase
Run new ZKMSA tool to figure '-server host:port' to pass ZKM
M bin/hbase-daemon.sh
Make default wait be longer.
This addresses bug hbase-2998.
http://issues.apache.org/jira/browse/hbase-2998
Diffs (updated)
-----
trunk/bin/hbase 1025815
trunk/bin/hbase-daemon.sh 1025815
trunk/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 1025815
trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java 1025815
trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java 1025815
trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1025815
trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java 1025815
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java 1025815
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 1025815
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java 1025815
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 1025815
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 1025815
Diff: http://review.cloudera.org/r/1057/diff
Testing
-------
Thanks,
stack
Re: Review Request: hbase-2998 rolling-restart.sh shouldn't rely on zoo.cfg
Posted by st...@duboce.net.
> On 2010-10-20 17:54:04, Jonathan Gray wrote:
> > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java, line 103
> > <http://review.cloudera.org/r/1057/diff/1/?file=15040#file15040line103>
> >
> >
>
> Jonathan Gray wrote:
> Not sure where my comment went :) Just wondering if in the rolling restart case, we aren't aborting, right?
>
> Is the stop() now a hard stop and that's why we need to close regions first?
Looking into this more --prompted by your comment -- this extra callout to shut down user regions in shutdown hook shouldn't be needed. Something else is going on. I'm digging in.
Right, we are not aborting when rolling restart. We are intercepting the jvm kill signal.
- stack
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1057/#review1594
-----------------------------------------------------------
On 2010-10-21 01:54:34, stack wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1057/
> -----------------------------------------------------------
>
> (Updated 2010-10-21 01:54:34)
>
>
> Review request for hbase, Jean-Daniel Cryans and Jonathan Gray.
>
>
> Summary
> -------
>
> Fix 'hbase zkcli' so it reads zk ensemble location from hbase config/zoo.cfg. This fixes rolling restart. Patch also includes fix so rolling restarts work on new master.
>
> A src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java
> Test for new TZMSA class.
> M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java
> Minor edit of javadoc.
> A src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java
> Tool to emit what ZooKeeperMain wants for a server argument.
> M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> (isAbort): Added.
> M src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java
> Shutdown hook now needs to startup region shutdowns since new
> master changed how shutdown sequence runs.
> M src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
> Don't do opens if server is stopped.
> M src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
> Minor formatting.
> M bin/hbase
> Run new ZKMSA tool to figure '-server host:port' to pass ZKM
> M bin/hbase-daemon.sh
> Make default wait be longer.
>
>
> This addresses bug hbase-2998.
> http://issues.apache.org/jira/browse/hbase-2998
>
>
> Diffs
> -----
>
> trunk/bin/hbase 1025815
> trunk/bin/hbase-daemon.sh 1025815
> trunk/src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java 1025815
> trunk/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java 1025815
> trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java 1025815
> trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 1025815
> trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java 1025815
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java 1025815
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java 1025815
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java 1025815
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 1025815
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 1025815
>
> Diff: http://review.cloudera.org/r/1057/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> stack
>
>
Re: Review Request: hbase-2998 rolling-restart.sh shouldn't rely on zoo.cfg
Posted by Jonathan Gray <jg...@apache.org>.
> On 2010-10-20 17:54:04, Jonathan Gray wrote:
> > trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java, line 103
> > <http://review.cloudera.org/r/1057/diff/1/?file=15040#file15040line103>
> >
> >
Not sure where my comment went :) Just wondering if in the rolling restart case, we aren't aborting, right?
Is the stop() now a hard stop and that's why we need to close regions first?
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1057/#review1594
-----------------------------------------------------------
On 2010-10-20 16:51:25, stack wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1057/
> -----------------------------------------------------------
>
> (Updated 2010-10-20 16:51:25)
>
>
> Review request for hbase, Jean-Daniel Cryans and Jonathan Gray.
>
>
> Summary
> -------
>
> Fix 'hbase zkcli' so it reads zk ensemble location from hbase config/zoo.cfg. This fixes rolling restart. Patch also includes fix so rolling restarts work on new master.
>
> A src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java
> Test for new TZMSA class.
> M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java
> Minor edit of javadoc.
> A src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java
> Tool to emit what ZooKeeperMain wants for a server argument.
> M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> (isAbort): Added.
> M src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java
> Shutdown hook now needs to startup region shutdowns since new
> master changed how shutdown sequence runs.
> M src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
> Don't do opens if server is stopped.
> M src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
> Minor formatting.
> M bin/hbase
> Run new ZKMSA tool to figure '-server host:port' to pass ZKM
> M bin/hbase-daemon.sh
> Make default wait be longer.
>
>
> This addresses bug hbase-2998.
> http://issues.apache.org/jira/browse/hbase-2998
>
>
> Diffs
> -----
>
> trunk/bin/hbase 1025785
> trunk/bin/hbase-daemon.sh 1025785
> trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java 1025785
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1025785
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java 1025785
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java 1025785
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java 1025785
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java PRE-CREATION
> trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java PRE-CREATION
>
> Diff: http://review.cloudera.org/r/1057/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> stack
>
>
Re: Review Request: hbase-2998 rolling-restart.sh shouldn't rely on zoo.cfg
Posted by Jonathan Gray <jg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1057/#review1594
-----------------------------------------------------------
Looking good!
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java
<http://review.cloudera.org/r/1057/#comment5394>
- Jonathan
On 2010-10-20 16:51:25, stack wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.cloudera.org/r/1057/
> -----------------------------------------------------------
>
> (Updated 2010-10-20 16:51:25)
>
>
> Review request for hbase, Jean-Daniel Cryans and Jonathan Gray.
>
>
> Summary
> -------
>
> Fix 'hbase zkcli' so it reads zk ensemble location from hbase config/zoo.cfg. This fixes rolling restart. Patch also includes fix so rolling restarts work on new master.
>
> A src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java
> Test for new TZMSA class.
> M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java
> Minor edit of javadoc.
> A src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java
> Tool to emit what ZooKeeperMain wants for a server argument.
> M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> (isAbort): Added.
> M src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java
> Shutdown hook now needs to startup region shutdowns since new
> master changed how shutdown sequence runs.
> M src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
> Don't do opens if server is stopped.
> M src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
> Minor formatting.
> M bin/hbase
> Run new ZKMSA tool to figure '-server host:port' to pass ZKM
> M bin/hbase-daemon.sh
> Make default wait be longer.
>
>
> This addresses bug hbase-2998.
> http://issues.apache.org/jira/browse/hbase-2998
>
>
> Diffs
> -----
>
> trunk/bin/hbase 1025785
> trunk/bin/hbase-daemon.sh 1025785
> trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java 1025785
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 1025785
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java 1025785
> trunk/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java 1025785
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java 1025785
> trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperMainServerArg.java PRE-CREATION
> trunk/src/test/java/org/apache/hadoop/hbase/zookeeper/TestZooKeeperMainServerArg.java PRE-CREATION
>
> Diff: http://review.cloudera.org/r/1057/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> stack
>
>