You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by je...@apache.org on 2019/10/21 22:54:47 UTC

[incubator-pinot] branch hybrid created (now af6e461)

This is an automated email from the ASF dual-hosted git repository.

jenniferdai pushed a change to branch hybrid
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.


      at af6e461  Adding logs for HybridClusterIntegrationTest

This branch includes the following new commits:

     new af6e461  Adding logs for HybridClusterIntegrationTest

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[incubator-pinot] 01/01: Adding logs for HybridClusterIntegrationTest

Posted by je...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

jenniferdai pushed a commit to branch hybrid
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git

commit af6e461a414bc28518e11097d1406496036054b7
Author: Jennifer Dai <jd...@linkedin.com>
AuthorDate: Mon Oct 21 15:54:27 2019 -0700

    Adding logs for HybridClusterIntegrationTest
---
 .../test/java/org/apache/pinot/controller/helix/ControllerTest.java  | 3 +++
 .../pinot/integration/tests/BaseClusterIntegrationTestSet.java       | 5 +++++
 .../apache/pinot/integration/tests/HybridClusterIntegrationTest.java | 2 ++
 3 files changed, 10 insertions(+)

diff --git a/pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java b/pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java
index 94edddb..ddca7d7 100644
--- a/pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java
+++ b/pinot-controller/src/test/java/org/apache/pinot/controller/helix/ControllerTest.java
@@ -111,6 +111,8 @@ public abstract class ControllerTest {
 
   private ZkStarter.ZookeeperInstance _zookeeperInstance;
 
+  private Logger LOGGER = LoggerFactory.getLogger(ControllerTest.class);
+
   protected String getHelixClusterName() {
     return getClass().getSimpleName();
   }
@@ -127,6 +129,7 @@ public abstract class ControllerTest {
     try {
       ZkStarter.stopLocalZkServer(_zookeeperInstance);
     } catch (Exception e) {
+      LOGGER.info("Could not stop local zk server");
       // Swallow exceptions
     }
   }
diff --git a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java
index 83b46ba..f78c6827 100644
--- a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java
+++ b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/BaseClusterIntegrationTestSet.java
@@ -41,6 +41,8 @@ import org.apache.pinot.common.config.TableNameBuilder;
 import org.apache.pinot.common.utils.CommonConstants;
 import org.apache.pinot.common.utils.JsonUtils;
 import org.apache.pinot.util.TestUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 import org.testng.Assert;
 
 
@@ -57,6 +59,8 @@ public abstract class BaseClusterIntegrationTestSet extends BaseClusterIntegrati
   private static final int DEFAULT_NUM_QUERIES_TO_GENERATE = 100;
   private static final int DEFAULT_MAX_NUM_QUERIES_TO_SKIP_IN_QUERY_FILE = 200;
 
+  protected static final Logger LOGGER = LoggerFactory.getLogger(BaseClusterIntegrationTest.class.getName());
+
   /**
    * Can be overridden to change default setting
    */
@@ -225,6 +229,7 @@ public abstract class BaseClusterIntegrationTestSet extends BaseClusterIntegrati
     getPinotConnection().execute("select $docId, $segmentName, $hostName from mytable where $docId = 5 limit 50");
     getPinotConnection().execute("select $docId, $segmentName, $hostName from mytable where $docId > 19998 limit 50");
     getPinotConnection().execute("select max($docId) from mytable group by $segmentName");
+    LOGGER.info("Successfully completed virtual column query test");
   }
 
   /**
diff --git a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/HybridClusterIntegrationTest.java b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/HybridClusterIntegrationTest.java
index ae6753d..d574467 100644
--- a/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/HybridClusterIntegrationTest.java
+++ b/pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/HybridClusterIntegrationTest.java
@@ -282,7 +282,9 @@ public class HybridClusterIntegrationTest extends BaseClusterIntegrationTestSet
     // Try deleting the tables and check that they have no routing table
     final String tableName = getTableName();
     dropOfflineTable(tableName);
+    LOGGER.info("Dropped offline table successfully");
     dropRealtimeTable(tableName);
+    LOGGER.info("Dropped realtime table successfully");
 
     // Routing table should not have any entries (length = 0) after deleting all tables
     TestUtils.waitForCondition(new Function<Void, Boolean>() {


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org