[jira] Commented: (FELIX-483) Log detailed information on invalid syntax in parsed repository xml requirements

["Guillaume Nodet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835639#action_12835639 ] 

Guillaume Nodet commented on FELIX-483:
---------------------------------------

One problem is that the setFilter() won't actually throw an exception if the syntax is invalid.
This will only be thrown when the filter is actually executed.
THe other problem is that the whole filter isn't present in the exception message, but only the tail.  
A better error reporting would be to validate the filter when the xml is parsed, though it might slow down the parsing a lot more (and it's already awfully slow).

> Log detailed information on invalid syntax in parsed repository xml requirements
> --------------------------------------------------------------------------------
>
>                 Key: FELIX-483
>                 URL: https://issues.apache.org/jira/browse/FELIX-483
>             Project: Felix
>          Issue Type: Improvement
>          Components: Bundle Repository (OBR)
>    Affects Versions: felix-1.0.0
>            Reporter: Alin Dreghiciu
>            Assignee: Richard S. Hall
>
> While parsing the repository xml BundleRepository logs an exception message while parsing requirements. This is fine but the information logged is not of too much use. 
> Eg. for the sogi alliance repository it will log something like:
> org.osgi.framework.InvalidSyntaxException: expected ~=|>=|<=
> Just with this information you cannot do to much.
> I suggest that RequirementImpl.setFilter to be changed to output also the failing filter.
> e.g. for the case above:
> Filter (&(package=org.apache.batik.i18n)(version>=1.6.0)(version<1.7.0))  parsing failed due to org.osgi.framework.InvalidSyntaxException: expected ~=|>=|<=

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.