You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "vinodkc (via GitHub)" <gi...@apache.org> on 2025/11/13 00:08:32 UTC
[PR] [SPARK-54208][CONNECT] Support TIME type data in SparkConnectResultSet [spark]
vinodkc opened a new pull request, #53026:
URL: https://github.com/apache/spark/pull/53026
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add TIME type support to the Spark Connect JDBC client
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
TIME is a fundamental SQL type required for JDBC compliance and interoperability.
### Note :
#### After this PR, there is Precision Loss on `SparkConnectResultSet.getTime()`
**Overview**
When using `ResultSet.getTime()` to retrieve TIME values from Spark Connect JDBC, there is a **precision loss from microseconds to milliseconds**.
**The Issue**
- **Spark SQL Support**: TIME values with microsecond precision (6 decimal places)
- Example: `time '12:34:56.123456'`
- **JDBC Limitation**: `java.sql.Time` class only supports millisecond precision (3 decimal places)
- **Result**: When calling `getTime()`, the last 3 digits (microseconds) are truncated
**Example**
```scala
// Input: time '12:34:56.123456' (microseconds: 123456)
val time = rs.getTime(1)
// Output: time.getTime() = 45296123 (only 123 milliseconds preserved)
// 12 hours = 12 × 3,600,000 ms = 43,200,000 ms
// 34 minutes = 34 × 60,000 ms = 2,040,000 ms
// 56 seconds = 56 × 1,000 ms = 56,000 ms
// 123 milliseconds = 123 ms
// Total = 45,296,123 ms
// Lost: 456 microseconds (the last 3 digits)
```
**Root Cause**
This is a fundamental limitation of the `java.sql.Time` class, which internally stores time as milliseconds rather than microseconds.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, it's part of a new feature under Spark connect JDBC support.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Added new UTs in `SparkConnectJdbcDataTypeSuite`
The tests verify that at least the millisecond precision (3 decimal places) is correctly preserved, but users should be aware that any sub-millisecond precision in the original data will be lost when using `getTime()`.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54208][CONNECT] Support TIME type in SparkConnectResultSet [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #53026:
URL: https://github.com/apache/spark/pull/53026#issuecomment-3525748495
I think precision loss is expected behavior due to the limitation of the JDBC specification, the current implementation is fine.
Hive JDBC driver doesn't support `getTime()` method as of the latest 4.2.0 RC0
https://github.com/apache/hive/blob/rel/release-4.2.0-rc0/jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java#L679
So for STS cases, we can't do E2E test even though we support it on the server side. BTW, STS converts some type of data into a String on the server side before returning to the client, so it may have no precision loss in display.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54208][CONNECT] Support TIME type in SparkConnectResultSet [spark]
Posted by "vinodkc (via GitHub)" <gi...@apache.org>.
vinodkc commented on code in PR #53026:
URL: https://github.com/apache/spark/pull/53026#discussion_r2524209112
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectResultSet.scala:
##########
@@ -501,28 +516,22 @@ class SparkConnectResultSet(
throw new SQLFeatureNotSupportedException
override def getDate(columnIndex: Int, cal: Calendar): Date = {
- val date = getDate(columnIndex)
- if (date == null || cal == null) {
- return date
- }
-
- val targetCalendar = cal.clone().asInstanceOf[Calendar]
- targetCalendar.setTime(date)
- targetCalendar.set(Calendar.HOUR_OF_DAY, 0)
- targetCalendar.set(Calendar.MINUTE, 0)
- targetCalendar.set(Calendar.SECOND, 0)
- targetCalendar.set(Calendar.MILLISECOND, 0)
- new Date(targetCalendar.getTimeInMillis)
+ // The Calendar parameter in JDBC methods is meant for timezone-aware types,
Review Comment:
Thanks for the comment, added method comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54208][CONNECT] Support TIME type in SparkConnectResultSet [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #53026:
URL: https://github.com/apache/spark/pull/53026#discussion_r2520824617
##########
sql/connect/client/jdbc/src/test/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectJdbcDataTypeSuite.scala:
##########
@@ -18,6 +18,7 @@
package org.apache.spark.sql.connect.client.jdbc
import java.sql.{ResultSet, SQLException, Types}
+import java.util.Calendar
Review Comment:
Could you make the CI happy, @vinodkc ?
```
[error] /__w/spark/spark/sql/connect/client/jdbc/src/test/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectJdbcDataTypeSuite.scala:21:18: Unused import
[error] Applicable -Wconf / @nowarn filters for this fatal warning: msg=<part of the message>, cat=unused-imports, site=org.apache.spark.sql.connect.client.jdbc
[error] import java.util.Calendar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54208][CONNECT] Support TIME type in SparkConnectResultSet [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #53026:
URL: https://github.com/apache/spark/pull/53026#issuecomment-3529721513
Merged to master/4.1 for Apache Spark 4.1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54208][CONNECT] Support TIME type in SparkConnectResultSet [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #53026:
URL: https://github.com/apache/spark/pull/53026#discussion_r2521861936
##########
sql/connect/client/jdbc/src/test/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectJdbcDataTypeSuite.scala:
##########
@@ -482,4 +434,133 @@ class SparkConnectJdbcDataTypeSuite extends ConnectFunSuite with RemoteSparkSess
assert(!rs.next())
}
}
+
+ test("get time type") {
+ withExecuteQuery("SELECT time '12:34:56.123456'") { rs =>
+ assert(rs.next())
+ val time = rs.getTime(1)
+ // Verify milliseconds are preserved (123 from 123456 microseconds)
+ val expectedMillis = 12 * 3600000L + 34 * 60000L + 56 * 1000L + 123L
+ assert(time.getTime === expectedMillis)
+ assert(!rs.wasNull)
+ assert(!rs.next())
+
+ val metaData = rs.getMetaData
+ assert(metaData.getColumnCount === 1)
+ assert(metaData.getColumnName(1) === "TIME '12:34:56.123456'")
+ assert(metaData.getColumnLabel(1) === "TIME '12:34:56.123456'")
+ assert(metaData.getColumnType(1) === Types.TIME)
+ assert(metaData.getColumnTypeName(1) === "TIME(6)")
+ assert(metaData.getColumnClassName(1) === "java.sql.Time")
+ assert(metaData.isSigned(1) === false)
+ assert(metaData.getPrecision(1) === 6)
+ assert(metaData.getScale(1) === 0)
+ assert(metaData.getColumnDisplaySize(1) === 15)
+ }
+ }
+
+ test("get time type with null") {
+ withExecuteQuery("SELECT cast(null as time)") { rs =>
+ assert(rs.next())
+ assert(rs.getTime(1) === null)
+ assert(rs.wasNull)
+ assert(!rs.next())
+
+ val metaData = rs.getMetaData
+ assert(metaData.getColumnCount === 1)
+ assert(metaData.getColumnName(1) === "CAST(NULL AS TIME(6))")
+ assert(metaData.getColumnLabel(1) === "CAST(NULL AS TIME(6))")
+ assert(metaData.getColumnType(1) === Types.TIME)
+ assert(metaData.getColumnTypeName(1) === "TIME(6)")
+ assert(metaData.getColumnClassName(1) === "java.sql.Time")
+ assert(metaData.isSigned(1) === false)
+ assert(metaData.getPrecision(1) === 6)
+ assert(metaData.getScale(1) === 0)
+ assert(metaData.getColumnDisplaySize(1) === 15)
+ }
+ }
+
+ test("get time type by column label") {
+ withExecuteQuery("SELECT time '09:15:30.456789' as test_time") { rs =>
+ assert(rs.next())
+ val time = rs.getTime("test_time")
+ // Verify milliseconds are preserved (456 from 456789 microseconds)
+ val expectedMillis = 9 * 3600000L + 15 * 60000L + 30 * 1000L + 456L
Review Comment:
can extract a helper function like:
```
private def timeToMillis(hour: Int, minute: Int, second: Int, millis: Int): Long = {
hour * 3600000L + minute * 60000L + second * 1000L + millis
}
```
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectResultSet.scala:
##########
@@ -147,8 +148,22 @@ class SparkConnectResultSet(
getColumnValue(columnIndex, null: Date) { idx => currentRow.getDate(idx) }
}
- override def getTime(columnIndex: Int): Time =
- throw new SQLFeatureNotSupportedException
+ override def getTime(columnIndex: Int): Time = {
+ getColumnValue(columnIndex, null: Time) { idx =>
+ val localTime = currentRow.get(idx).asInstanceOf[LocalTime]
+ // Convert LocalTime to milliseconds since midnight to preserve fractional seconds.
+ // Note: java.sql.Time can only store up to millisecond precision (3 digits).
+ // For TIME types with higher precision (TIME(4-9)), microseconds/nanoseconds are truncated.
+ // If user needs full precision,
+ // should use: getObject(columnIndex, classOf[java.time.LocalTime])
+ val millisSinceMidnight =
Review Comment:
Can we use `val millisSinceMidnight = java.time.temporal.ChronoUnit.MILLIS.between(LocalTime.MIDNIGHT, localTime)`?
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectResultSet.scala:
##########
@@ -501,28 +516,22 @@ class SparkConnectResultSet(
throw new SQLFeatureNotSupportedException
override def getDate(columnIndex: Int, cal: Calendar): Date = {
- val date = getDate(columnIndex)
- if (date == null || cal == null) {
- return date
- }
-
- val targetCalendar = cal.clone().asInstanceOf[Calendar]
- targetCalendar.setTime(date)
- targetCalendar.set(Calendar.HOUR_OF_DAY, 0)
- targetCalendar.set(Calendar.MINUTE, 0)
- targetCalendar.set(Calendar.SECOND, 0)
- targetCalendar.set(Calendar.MILLISECOND, 0)
- new Date(targetCalendar.getTimeInMillis)
+ // The Calendar parameter in JDBC methods is meant for timezone-aware types,
Review Comment:
I suggest turning it into class or method comments so that it can be reflected in the Javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54208][CONNECT] Support TIME type in SparkConnectResultSet [spark]
Posted by "vinodkc (via GitHub)" <gi...@apache.org>.
vinodkc commented on code in PR #53026:
URL: https://github.com/apache/spark/pull/53026#discussion_r2524203623
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectResultSet.scala:
##########
@@ -147,8 +148,22 @@ class SparkConnectResultSet(
getColumnValue(columnIndex, null: Date) { idx => currentRow.getDate(idx) }
}
- override def getTime(columnIndex: Int): Time =
- throw new SQLFeatureNotSupportedException
+ override def getTime(columnIndex: Int): Time = {
+ getColumnValue(columnIndex, null: Time) { idx =>
+ val localTime = currentRow.get(idx).asInstanceOf[LocalTime]
+ // Convert LocalTime to milliseconds since midnight to preserve fractional seconds.
+ // Note: java.sql.Time can only store up to millisecond precision (3 digits).
+ // For TIME types with higher precision (TIME(4-9)), microseconds/nanoseconds are truncated.
+ // If user needs full precision,
+ // should use: getObject(columnIndex, classOf[java.time.LocalTime])
+ val millisSinceMidnight =
Review Comment:
Yes, Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54208][CONNECT] Support TIME type in SparkConnectResultSet [spark]
Posted by "vinodkc (via GitHub)" <gi...@apache.org>.
vinodkc commented on PR #53026:
URL: https://github.com/apache/spark/pull/53026#issuecomment-3525231576
Hi @dongjoon-hyun , Please see my reply
> What about the compatibility with Spark Thrift Server behavior,
It seems ,STS doesn't support getTime() method , I see this error from STS client
```
java.sql.SQLFeatureNotSupportedException: Method not supported
at org.apache.hive.jdbc.HiveBaseResultSet.getTime(HiveBaseResultSet.java:552)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54208][CONNECT] Support TIME type in SparkConnectResultSet [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #53026:
URL: https://github.com/apache/spark/pull/53026#issuecomment-3525300081
Got it~
cc @pan3793 , @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54208][CONNECT] Support TIME type in SparkConnectResultSet [spark]
Posted by "vinodkc (via GitHub)" <gi...@apache.org>.
vinodkc commented on code in PR #53026:
URL: https://github.com/apache/spark/pull/53026#discussion_r2524203623
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectResultSet.scala:
##########
@@ -147,8 +148,22 @@ class SparkConnectResultSet(
getColumnValue(columnIndex, null: Date) { idx => currentRow.getDate(idx) }
}
- override def getTime(columnIndex: Int): Time =
- throw new SQLFeatureNotSupportedException
+ override def getTime(columnIndex: Int): Time = {
+ getColumnValue(columnIndex, null: Time) { idx =>
+ val localTime = currentRow.get(idx).asInstanceOf[LocalTime]
+ // Convert LocalTime to milliseconds since midnight to preserve fractional seconds.
+ // Note: java.sql.Time can only store up to millisecond precision (3 digits).
+ // For TIME types with higher precision (TIME(4-9)), microseconds/nanoseconds are truncated.
+ // If user needs full precision,
+ // should use: getObject(columnIndex, classOf[java.time.LocalTime])
+ val millisSinceMidnight =
Review Comment:
Yes, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54208][CONNECT] Support TIME type in SparkConnectResultSet [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #53026: [SPARK-54208][CONNECT] Support TIME type in SparkConnectResultSet
URL: https://github.com/apache/spark/pull/53026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org