You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org> on 2019/08/17 02:27:06 UTC
[Impala-ASF-CR] IMPALA-8872: Override httpcore from libthrift to 4.4.6
Bharath Vissapragada has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14087
Change subject: IMPALA-8872: Override httpcore from libthrift to 4.4.6
......................................................................
IMPALA-8872: Override httpcore from libthrift to 4.4.6
When deploying a cluster with Ranger publishing audits to SOLR,
we noticed that the SPNEGO request consistently fails with
httpcore 4.4.1 pulled in by thrift.
The error goes away with httpcore v4.4.6 (manually tested). This
patch overrides the dependency.
Change-Id: I675356d002354b0aff439f0635e30f4610a96989
---
M fe/pom.xml
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/14087/1
--
To view, visit http://gerrit.cloudera.org:8080/14087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I675356d002354b0aff439f0635e30f4610a96989
Gerrit-Change-Number: 14087
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
[Impala-ASF-CR] IMPALA-8872: Override httpcore from libthrift to 4.4.6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14087 )
Change subject: IMPALA-8872: Override httpcore from libthrift to 4.4.6
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4814/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I675356d002354b0aff439f0635e30f4610a96989
Gerrit-Change-Number: 14087
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 02:36:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8872: Override httpcore from libthrift to 4.4.9
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker, Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14087
to look at the new patch set (#3).
Change subject: IMPALA-8872: Override httpcore from libthrift to 4.4.9
......................................................................
IMPALA-8872: Override httpcore from libthrift to 4.4.9
When deploying a cluster with Ranger publishing audits to SOLR,
we noticed that the SPNEGO request consistently fails with
httpcore 4.4.1 pulled in by thrift.
The error goes away with httpcore v4.4.9 (manually tested). This
patch overrides the dependency.
Change-Id: I675356d002354b0aff439f0635e30f4610a96989
---
M fe/pom.xml
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/14087/3
--
To view, visit http://gerrit.cloudera.org:8080/14087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I675356d002354b0aff439f0635e30f4610a96989
Gerrit-Change-Number: 14087
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8872: Override httpcore from libthrift to 4.4.6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14087 )
Change subject: IMPALA-8872: Override httpcore from libthrift to 4.4.6
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4294/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I675356d002354b0aff439f0635e30f4610a96989
Gerrit-Change-Number: 14087
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 03:15:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8872: Override httpcore from libthrift to 4.4.6
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14087 )
Change subject: IMPALA-8872: Override httpcore from libthrift to 4.4.6
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4293/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I675356d002354b0aff439f0635e30f4610a96989
Gerrit-Change-Number: 14087
Gerrit-PatchSet: 1
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 03:07:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8872: Override httpcore from libthrift to 4.4.9
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14087 )
Change subject: IMPALA-8872: Override httpcore from libthrift to 4.4.9
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
thanks for the quick review. Carrying +2. (Not rerunning the GVO because I just fixed comments, will carry it once the job finishes).
http://gerrit.cloudera.org:8080/#/c/14087/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14087/2//COMMIT_MSG@7
PS2, Line 7: 4.4.9
> Should this say "4.4.9"?
Done
http://gerrit.cloudera.org:8080/#/c/14087/2/fe/pom.xml
File fe/pom.xml:
http://gerrit.cloudera.org:8080/#/c/14087/2/fe/pom.xml@361
PS2, Line 361: to ke
> nit: double word
Done
--
To view, visit http://gerrit.cloudera.org:8080/14087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I675356d002354b0aff439f0635e30f4610a96989
Gerrit-Change-Number: 14087
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 04:23:25 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8872: Override httpcore from libthrift to 4.4.6
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14087 )
Change subject: IMPALA-8872: Override httpcore from libthrift to 4.4.6
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Thanks for fixing this. LGTM but had 2 nits.
http://gerrit.cloudera.org:8080/#/c/14087/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14087/2//COMMIT_MSG@7
PS2, Line 7: 4.4.6
Should this say "4.4.9"?
http://gerrit.cloudera.org:8080/#/c/14087/2/fe/pom.xml
File fe/pom.xml:
http://gerrit.cloudera.org:8080/#/c/14087/2/fe/pom.xml@361
PS2, Line 361: to to
nit: double word
--
To view, visit http://gerrit.cloudera.org:8080/14087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I675356d002354b0aff439f0635e30f4610a96989
Gerrit-Change-Number: 14087
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 04:04:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8872: Override httpcore from libthrift to 4.4.9
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/14087 )
Change subject: IMPALA-8872: Override httpcore from libthrift to 4.4.9
......................................................................
Patch Set 3: Verified+1
Unrelated flaky test failure, merging.
--
To view, visit http://gerrit.cloudera.org:8080/14087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I675356d002354b0aff439f0635e30f4610a96989
Gerrit-Change-Number: 14087
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 15:11:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8872: Override httpcore from libthrift to 4.4.9
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14087 )
Change subject: IMPALA-8872: Override httpcore from libthrift to 4.4.9
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4814/
--
To view, visit http://gerrit.cloudera.org:8080/14087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I675356d002354b0aff439f0635e30f4610a96989
Gerrit-Change-Number: 14087
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 06:40:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8872: Override httpcore from libthrift to 4.4.6
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Hello Vihang Karajgaonkar, Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14087
to look at the new patch set (#2).
Change subject: IMPALA-8872: Override httpcore from libthrift to 4.4.6
......................................................................
IMPALA-8872: Override httpcore from libthrift to 4.4.6
When deploying a cluster with Ranger publishing audits to SOLR,
we noticed that the SPNEGO request consistently fails with
httpcore 4.4.1 pulled in by thrift.
The error goes away with httpcore v4.4.9 (manually tested). This
patch overrides the dependency.
Change-Id: I675356d002354b0aff439f0635e30f4610a96989
---
M fe/pom.xml
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/14087/2
--
To view, visit http://gerrit.cloudera.org:8080/14087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I675356d002354b0aff439f0635e30f4610a96989
Gerrit-Change-Number: 14087
Gerrit-PatchSet: 2
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
[Impala-ASF-CR] IMPALA-8872: Override httpcore from libthrift to 4.4.9
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14087 )
Change subject: IMPALA-8872: Override httpcore from libthrift to 4.4.9
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4295/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I675356d002354b0aff439f0635e30f4610a96989
Gerrit-Change-Number: 14087
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Aug 2019 05:02:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8872: Override httpcore from libthrift to 4.4.9
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14087 )
Change subject: IMPALA-8872: Override httpcore from libthrift to 4.4.9
......................................................................
IMPALA-8872: Override httpcore from libthrift to 4.4.9
When deploying a cluster with Ranger publishing audits to SOLR,
we noticed that the SPNEGO request consistently fails with
httpcore 4.4.1 pulled in by thrift.
The error goes away with httpcore v4.4.9 (manually tested). This
patch overrides the dependency.
Change-Id: I675356d002354b0aff439f0635e30f4610a96989
Reviewed-on: http://gerrit.cloudera.org:8080/14087
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Tested-by: Bharath Vissapragada <bh...@cloudera.com>
---
M fe/pom.xml
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Bharath Vissapragada: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14087
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I675356d002354b0aff439f0635e30f4610a96989
Gerrit-Change-Number: 14087
Gerrit-PatchSet: 4
Gerrit-Owner: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>