You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Matthew Jacobs (Code Review)" <ge...@cloudera.org> on 2017/07/20 16:35:11 UTC

[kudu-CR] KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cmake patch 

Matthew Jacobs has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7473

Change subject: KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cmake patch
......................................................................

KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cmake patch

Updates the patch and adds a note in vars.sh to hint that
CMake version changes may require updating the patch.

Testing: Locally tested by forcing the patch to always be
applied.

Change-Id: I689d57c736ef6845d44b246b0be1cf83aa7e59e4
---
M thirdparty/patches/cmake-issue-15873-dont-use-select.patch
M thirdparty/vars.sh
2 files changed, 19 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/7473/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I689d57c736ef6845d44b246b0be1cf83aa7e59e4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>

[kudu-CR] KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cmake patch

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cmake patch
......................................................................


Patch Set 2:

> Thanks for fixing this, MJ. My bad for missing it

NP at all, thanks for the prompt review.

-- 
To view, visit http://gerrit.cloudera.org:8080/7473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I689d57c736ef6845d44b246b0be1cf83aa7e59e4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cmake patch

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cmake patch
......................................................................


Patch Set 1: Code-Review+2

Thanks for fixing this, MJ. My bad for missing it

-- 
To view, visit http://gerrit.cloudera.org:8080/7473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I689d57c736ef6845d44b246b0be1cf83aa7e59e4
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR] KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cmake patch

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.

Change subject: KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cmake patch
......................................................................


KUDU-2072: upgrade to cmake 3.9.0 breaks sles12sp0 cmake patch

Updates the patch and adds a note in vars.sh to hint that
CMake version changes may require updating the patch.

Testing: Locally tested by forcing the patch to always be
applied.

Change-Id: I689d57c736ef6845d44b246b0be1cf83aa7e59e4
Reviewed-on: http://gerrit.cloudera.org:8080/7473
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M thirdparty/patches/cmake-issue-15873-dont-use-select.patch
M thirdparty/vars.sh
2 files changed, 19 insertions(+), 4 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/7473
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I689d57c736ef6845d44b246b0be1cf83aa7e59e4
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>