You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@horaedb.apache.org by ch...@apache.org on 2024/03/19 06:23:44 UTC

(incubator-horaedb) tag v2.0.0-rc.5 created (now 1c56d2b1)

This is an automated email from the ASF dual-hosted git repository.

chunshao pushed a change to tag v2.0.0-rc.5
in repository https://gitbox.apache.org/repos/asf/incubator-horaedb.git


      at 1c56d2b1 (commit)
This tag includes the following new commits:

     new 1c56d2b1 chore: remove tini binary (#1503)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org

(incubator-horaedb) 01/01: chore: remove tini binary (#1503)

Posted by ch...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

chunshao pushed a commit to tag v2.0.0-rc.5
in repository https://gitbox.apache.org/repos/asf/incubator-horaedb.git

commit 1c56d2b1d70fc740fc6a62b92b4ac0cbd5f904d7
Author: Jiacai Liu <de...@liujiacai.net>
AuthorDate: Mon Mar 18 19:05:23 2024 +0800

    chore: remove tini binary (#1503)
    
    ## Rationale
    Our repo should not contain any binaries.
    
    ## Detailed Changes
    - Download tini instead of hard copy
    
    ## Test Plan
    CI
    
    Also I use command below to ensure no other binaries exists.
    ```
    fd -t file --exclude target --exec file {} \; | grep -v ASCII | grep -v UTF-8
    ```
---
 .gitignore            |   1 +
 Dockerfile            |   3 ++-
 docker/tini           | Bin 24064 -> 0 bytes
 horaemeta/Dockerfile  |   3 ++-
 horaemeta/docker/tini | Bin 24064 -> 0 bytes
 5 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/.gitignore b/.gitignore
index 1cdba5be..f3b4b08a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -10,3 +10,4 @@ integration_tests/dist_query/output
 .tools
 bin
 coverage.txt
+tini
diff --git a/Dockerfile b/Dockerfile
index 0de3d643..6e94e51a 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -46,7 +46,8 @@ RUN chmod +x /usr/bin/horaedb-server
 COPY ./docker/entrypoint.sh /entrypoint.sh
 COPY ./docs/minimal.toml /etc/horaedb/horaedb.toml
 
-COPY ./docker/tini /tini
+ARG TINI_VERSION=v0.19.0
+ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini
 RUN chmod +x /tini
 
 ARG USER=horae
diff --git a/docker/tini b/docker/tini
deleted file mode 100644
index 03af82f0..00000000
Binary files a/docker/tini and /dev/null differ
diff --git a/horaemeta/Dockerfile b/horaemeta/Dockerfile
index 5841c2a8..9512582a 100644
--- a/horaemeta/Dockerfile
+++ b/horaemeta/Dockerfile
@@ -44,7 +44,8 @@ RUN chmod +x /usr/bin/horaemeta-server
 COPY ./docker/entrypoint.sh /entrypoint.sh
 COPY ./config/example-standalone.toml /etc/horaemeta/horaemeta.toml
 
-COPY ./docker/tini /tini
+ARG TINI_VERSION=v0.19.0
+ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini
 RUN chmod +x /tini
 
 ARG USER horae
diff --git a/horaemeta/docker/tini b/horaemeta/docker/tini
deleted file mode 100644
index 03af82f0..00000000
Binary files a/horaemeta/docker/tini and /dev/null differ


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org