You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yangwei-x (via GitHub)" <gi...@apache.org> on 2025/03/15 15:13:59 UTC

[PR] arm/nucleo-f746zg: Add board example with feature note [nuttx]

yangwei-x opened a new pull request, #15995:
URL: https://github.com/apache/nuttx/pull/15995

   ## arm/nucleo-f746zg: Add board example with app note
   
   Add a example for board nucleo-f746zg with following apps
   
   ```
   NuttShell (NSH) NuttX-12.8.0
   nsh>
   nsh> help
   help usage:  help [-v] [<cmd>]
   
       .           cp          false       mkdir       rmdir       umount
       [           cmp         fdinfo      mkfifo      rmmod       unset
       ?           dirname     free        mkrd        route       uptime
       addroute    dd          help        mount       set         usleep
       alias       delroute    hexdump     mv          sleep       watch
       unalias     df          ifconfig    nslookup    source      xd
       arp         dmesg       insmod      pidof       test        wait
       basename    echo        kill        printf      time
       break       exec        pkill       ps          true
       cat         exit        ls          pwd         truncate
       cd          expr        lsmod       rm          uname
   
   Builtin Apps:
       note       nsh        ping       renew      sh         telnetd    trace
   nsh>
   ```
   
   
   ## Impact
   
   Only valid for board nucleo-f746zg
   
   
   ## Testing
   
   * OS: Build success on  Ubuntu 24.04 
   * Compiler: arm-none-eabi-gcc (15:13.2.rel1-2) 13.2.1 20231009
   
   ```
   NuttShell (NSH) NuttX-12.8.0
   nsh>
   nsh> help
   help usage:  help [-v] [<cmd>]
   
       .           cp          false       mkdir       rmdir       umount
       [           cmp         fdinfo      mkfifo      rmmod       unset
       ?           dirname     free        mkrd        route       uptime
       addroute    dd          help        mount       set         usleep
       alias       delroute    hexdump     mv          sleep       watch
       unalias     df          ifconfig    nslookup    source      xd
       arp         dmesg       insmod      pidof       test        wait
       basename    echo        kill        printf      time
       break       exec        pkill       ps          true
       cat         exit        ls          pwd         truncate
       cd          expr        lsmod       rm          uname
   
   Builtin Apps:
       note       nsh        ping       renew      sh         telnetd    trace
   nsh> trace -h
   
   Usage: trace [-n][<name>] <subcommand>...
   Subcommand:
    start   [-c][<duration>]            : Start task tracing
    stop                                : Stop task tracing
    cmd     [-c] <command> [<args>...]  : Get the trace while running <command>
    dump    [-a][-c][<filename>]        : Output the trace result
                                          [-a] <Android SysTrace>
    mode    [{+|-}{o|w|s|a|i|d}...]     : Set task trace options
    switch  [+|-]                       : Configure switch trace filter
    print   [+|-]                       : Configure dump trace filter
   nsh> note -h
   note_manote_daemon: Running
   note_daemon: Opening /dev/note/ram
   in<noname>-5   [0] 1072.936000000: sched_switch: prev_comm=<noname> prev_pid=0 prev_prio=255 prev_state=R ==> next_comm=<noname> next_pid=5 next_prio=100
   : Starting the note_daemon
   note_main: note_daemon started
   nsh> <noname>-3   [0] 1072.937000000: sched_switch: prev_comm=<noname> prev_pid=5 prev_prio=100 prev_state=R ==> next_comm=<noname> next_pid=3 next_prio=100
   <noname>-3   [0] 1073.792000000: sched_switch: prev_comm=<noname> prev_pid=3 prev_prio=100 prev_state=R ==> next_comm=<noname> next_pid=3 next_prio=100
   <noname>-3   [0] 1074.265000000: sched_switch: prev_comm=<noname> prev_pid=3 prev_prio=100 prev_state=R ==> next_comm=<noname> next_pid=3 next_prio=100
   <noname>-1   [0] 1074.702000000: sched_switch: prev_comm=<noname> prev_pid=3 prev_prio=100 prev_state=R ==> next_comm=<noname> next_pid=1 next_prio=224
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arm/nucleo-f746zg: Add example with apps note and trace [nuttx]

Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao merged PR #15995:
URL: https://github.com/apache/nuttx/pull/15995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arm/nucleo-f746zg: Add board example with feature note [nuttx]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #15995:
URL: https://github.com/apache/nuttx/pull/15995#issuecomment-2726737549

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary.
   
   
   
   The PR mostly meets the NuttX requirements, but could be improved.
   
   **Strengths:**
   
   * **Summary:** Clearly states the change (adding a board example with apps). The list of apps is helpful.
   * **Testing:** Provides host OS, compiler, and target information.  Includes "after" logs demonstrating functionality.
   
   **Weaknesses:**
   
   * **Summary:**  Lacks a related issue reference if one exists. Doesn't explain *why* this example is necessary (what use case it addresses).  Doesn't explicitly detail *how* the change was implemented (what files were added/modified).
   * **Impact:** While stating it's only for `nucleo-f746zg`, this section needs more detail.  All the "NO / YES" questions should be explicitly answered. Even if the answer is NO, stating it explicitly improves clarity.  For example:
       * `Impact on user (will user need to adapt to change)? NO`
       * `Impact on build (will build process change)? YES (The build system will now recognize and build for the nucleo-f746zg configuration)` (or something similar)
   * **Testing:** Missing "before" logs. While not strictly required if there was no prior functionality, it's good practice to show the absence of the example beforehand.  The logs themselves aren't very illustrative.  It would be better to show commands specific to the new example, demonstrating its unique features, rather than just generic `help` and `trace -h`.
   
   
   **Recommendation:**
   
   To fully meet the requirements, the PR should be revised to include:
   
   * **Summary:** A more detailed explanation of the motivation and implementation of the change.  A link to a related issue if one exists.
   * **Impact:** Explicitly answer all questions, even if the answer is NO.  Clarify how the build system is impacted.
   * **Testing:** Add "before" logs demonstrating the lack of the example prior to the change.  Provide more specific and illustrative "after" logs showcasing the new example's functionality.
   
   
   By addressing these points, the PR will be much clearer and easier for reviewers to evaluate.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] arm/nucleo-f746zg: Add example with apps note and trace [nuttx]

Posted by "yangwei-x (via GitHub)" <gi...@apache.org>.
yangwei-x commented on PR #15995:
URL: https://github.com/apache/nuttx/pull/15995#issuecomment-2727058454

   > Please remove this merge, use git rebase to fix it
   
   Removed. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org