You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Eduardo Ponce (Jira)" <ji...@apache.org> on 2021/10/15 01:33:00 UTC
[jira] [Created] (ARROW-14332) [C++] Rename type traits utilities
to improve semantic consistency
Eduardo Ponce created ARROW-14332:
-------------------------------------
Summary: [C++] Rename type traits utilities to improve semantic consistency
Key: ARROW-14332
URL: https://issues.apache.org/jira/browse/ARROW-14332
Project: Apache Arrow
Issue Type: Improvement
Reporter: Eduardo Ponce
Fix For: 7.0.0
There are semantic differences between *enable_ifs-related* utils and *is_xxx* functions with the same name. For example, *is_binary_like* [here](https://github.com/apache/arrow/blob/master/cpp/src/arrow/type_traits.h#L596) != [here](https://github.com/apache/arrow/blob/master/cpp/src/arrow/type_traits.h#L924). The former includes binary only and the latter binary/string types.
Also, the *_like* suffix seems unwarranted as they always refer to binary or string.
Also, the *is_fixed_size_binary* includes both _FixedSizeBinaryType_ and _DecimalXXXType_. A better name is *is_base_fixed_size_binary* to match how binary/string utils are used.
_Note_: There might be other inconsistencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)