You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/02 18:33:53 UTC

[GitHub] [arrow] astrelsky commented on a change in pull request #12518: ARROW-15791: [Go] ipc FileWriter negative WaitGroup counter

astrelsky commented on a change in pull request #12518:
URL: https://github.com/apache/arrow/pull/12518#discussion_r817987245



##########
File path: go/arrow/ipc/writer.go
##########
@@ -225,6 +225,7 @@ func (w *recordEncoder) compressBodyBuffers(p *Payload) error {
 	defer cancel()
 
 	for i := 0; i < w.compressNP; i++ {
+		wg.Add(1)

Review comment:
       > is there a uni test that can be added for this?
   
   If there isn't already a failing test then one would need to be added for using an `ipc.FileWriter` with `ipc.WithCompressConcurrency` set to a value greater than 0.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org