[GitHub] [arrow] davisusanibar commented on a diff in pull request #35314: GH-34723: [Java] Enable log trace for Netty allocator memory usage

["davisusanibar (via GitHub)" <gi...@apache.org>]

davisusanibar commented on code in PR #35314:
URL: https://github.com/apache/arrow/pull/35314#discussion_r1176423765


##########
java/memory/memory-netty/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java:
##########
@@ -265,7 +265,7 @@ public MemoryStatusThread() {
       @Override
       public void run() {
         while (true) {
-          memoryLogger.trace("Memory Usage: \n{}", PooledByteBufAllocatorL.this.toString());
+          memoryLogger.trace("Memory Usage: \n{}", PooledByteBufAllocatorL.this.allocator);

Review Comment:
   > Since this is a background thread, doesn't the test need to account for a potential race condition?
   
   Oh, please could you help me how/when this method execute/run? Or Could you help me with an example about the current race condition problem? This will help me to understand in more detail how this run behind the scene.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org