You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/05/27 21:22:30 UTC
[GitHub] [samza] abhishekshivanna opened a new pull request #1369: SAMZA-2533: Fix DiagnosticsUtil to use configured MetricsReporterFactory
abhishekshivanna opened a new pull request #1369:
URL: https://github.com/apache/samza/pull/1369
DiagnosticsUtil#buildDiagnosticsManager currently hard codes
the creation of MetricsSnapshotReporter.
This patch fixes this and creates the MetricsReporter
using the factory defined in configs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] mynameborat merged pull request #1369: SAMZA-2533: Fix DiagnosticsUtil to use configured MetricsReporterFactory
Posted by GitBox <gi...@apache.org>.
mynameborat merged pull request #1369:
URL: https://github.com/apache/samza/pull/1369
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] rmatharu commented on pull request #1369: SAMZA-2533: Fix DiagnosticsUtil to use configured MetricsReporterFactory
Posted by GitBox <gi...@apache.org>.
rmatharu commented on pull request #1369:
URL: https://github.com/apache/samza/pull/1369#issuecomment-636054651
Perhaps adding a test in TestDiagnosticsManager would be prudent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] abhishekshivanna commented on pull request #1369: SAMZA-2533: Fix DiagnosticsUtil to use configured MetricsReporterFactory
Posted by GitBox <gi...@apache.org>.
abhishekshivanna commented on pull request #1369:
URL: https://github.com/apache/samza/pull/1369#issuecomment-637091606
Based on comments received on https://github.com/apache/samza/pull/1368. This patch removes exposing the producer in `MetricsSnapshotReporter`.
Rather, instantiates two separate producers for `DiagnotsticsManager` and `MetricsSnapshotReporter`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] xiefan46 commented on pull request #1369: SAMZA-2533: Fix DiagnosticsUtil to use configured MetricsReporterFactory
Posted by GitBox <gi...@apache.org>.
xiefan46 commented on pull request #1369:
URL: https://github.com/apache/samza/pull/1369#issuecomment-635041429
lgtm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] abhishekshivanna commented on pull request #1369: SAMZA-2533: Fix DiagnosticsUtil to use configured MetricsReporterFactory
Posted by GitBox <gi...@apache.org>.
abhishekshivanna commented on pull request #1369:
URL: https://github.com/apache/samza/pull/1369#issuecomment-636527332
> Perhaps adding a test in TestDiagnosticsManager would be prudent?
This patch doesn't change the DiagnoticsManager (hence nothing to change in TestDiagnosticsManager ??). Instead, I added a test to verify that the reporter created (using `DiagnosticsUtil#buildDiagnosticsManager`) comes from the factory in configs.
Let me know if this looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] abhishekshivanna commented on pull request #1369: SAMZA-2533: Fix DiagnosticsUtil to use configured MetricsReporterFactory
Posted by GitBox <gi...@apache.org>.
abhishekshivanna commented on pull request #1369:
URL: https://github.com/apache/samza/pull/1369#issuecomment-634948547
Please note: `MetricsSnapshotReporter#getProducer` will be removed once https://github.com/apache/samza/pull/1368 is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] rmatharu commented on a change in pull request #1369: SAMZA-2533: Fix DiagnosticsUtil to use configured MetricsReporterFactory
Posted by GitBox <gi...@apache.org>.
rmatharu commented on a change in pull request #1369:
URL: https://github.com/apache/samza/pull/1369#discussion_r438316408
##########
File path: samza-core/src/test/resources/log4j2.xml
##########
@@ -0,0 +1,32 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
+ license agreements. See the NOTICE file distributed with this work for additional
+ information regarding copyright ownership. The ASF licenses this file to
+ you under the Apache License, Version 2.0 (the "License"); you may not use
+ this file except in compliance with the License. You may obtain a copy of
+ the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required
+ by applicable law or agreed to in writing, software distributed under the
+ License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS
+ OF ANY KIND, either express or implied. See the License for the specific
+ language governing permissions and limitations under the License. -->
+
+
+<Configuration strict="true">
+
+ <Appenders>
+ <Console name="STDOUT" target="SYSTEM_OUT">
+ <PatternLayout pattern="%d{yyyy-MM-dd HH:mm:ss} %-5p %c{1}:%L - %m%n"/>
+ </Console>
+ </Appenders>
+
+ <Loggers>
+ <Logger name="org.apache" level="debug" additivity="false">
+ <AppenderRef ref="STDOUT"/>
+ </Logger>
+
+ <Root level="debug">
+ <AppenderRef ref="STDOUT"/>
+ </Root>
+ </Loggers>
+
+</Configuration>
Review comment:
Should we remove this file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org