You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Martin Ritchie (JIRA)" <qp...@incubator.apache.org> on 2008/07/08 15:42:31 UTC
[jira] Created: (QPID-1167) Queue alerting nolonger works.
Queue alerting nolonger works.
------------------------------
Key: QPID-1167
URL: https://issues.apache.org/jira/browse/QPID-1167
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: M2.1
Reporter: Martin Ritchie
Fix For: M3
Summary:
This was broken by commit:
#629731 Thu Feb 21 02:09:03 PST 2008 rgodfrey
The update to AMQQueue to create a list active of NotificationChecks is fine as a performance enhancement the problem is that on creation all alerts are 0 which means that no NotificationChecks are registered.
In some places the AMQQueue creation is followed by Configurator.configure(...); however this does not call the set Methods but directly changes the variables so the NotificationCheck registrations are still missing.
The virtualhost has a getConfiguredObject() which should be used to ensure all object creations are correctly configured with the commons Configuration values. However all configured objects will also need an init() method as we cannot use the constructor for things such as registering checks based on configurable values. These values are not set until later (the Configurator.configure(...) call to be exact.)
Changes Required:
- All Configurable object creations need to be checked to ensure that the object is correctly configured based on the commons.Configuration.
- For consistency all Configurable objects should have an init() method to perform any final setup after the configured values have been set.
Testing:
This needs additional testing. In particular the configuration values for alerting need to be set via a real configuration not via the set<Notification>() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1167) Queue alerting nolonger works.
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner updated QPID-1167:
--------------------------------
Component/s: (was: Java Broker)
Java Tests
Fix Version/s: (was: M3)
M4
Priority: Major (was: Blocker)
Affects Version/s: (was: M2.1)
M4
> Queue alerting nolonger works.
> ------------------------------
>
> Key: QPID-1167
> URL: https://issues.apache.org/jira/browse/QPID-1167
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Aidan Skinner
> Fix For: M4
>
>
> Summary:
> This was broken by commit:
> #629731 Thu Feb 21 02:09:03 PST 2008 rgodfrey
> The update to AMQQueue to create a list active of NotificationChecks is fine as a performance enhancement the problem is that on creation all alerts are 0 which means that no NotificationChecks are registered.
> In some places the AMQQueue creation is followed by Configurator.configure(...); however this does not call the set Methods but directly changes the variables so the NotificationCheck registrations are still missing.
> The virtualhost has a getConfiguredObject() which should be used to ensure all object creations are correctly configured with the commons Configuration values. However all configured objects will also need an init() method as we cannot use the constructor for things such as registering checks based on configurable values. These values are not set until later (the Configurator.configure(...) call to be exact.)
> Changes Required:
> - All Configurable object creations need to be checked to ensure that the object is correctly configured based on the commons.Configuration.
> - For consistency all Configurable objects should have an init() method to perform any final setup after the configured values have been set.
> Testing:
> This needs additional testing. In particular the configuration values for alerting need to be set via a real configuration not via the set<Notification>() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1167) Queue alerting nolonger works.
Posted by "Marnie McCormack (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marnie McCormack reassigned QPID-1167:
--------------------------------------
Assignee: Rob Godfrey (was: Aidan Skinner)
Hi - we think this work is complete but requires review. Could you take a look and clickety-click please ? Thanks.
> Queue alerting nolonger works.
> ------------------------------
>
> Key: QPID-1167
> URL: https://issues.apache.org/jira/browse/QPID-1167
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Rob Godfrey
> Fix For: M4
>
>
> Summary:
> This was broken by commit:
> #629731 Thu Feb 21 02:09:03 PST 2008 rgodfrey
> The update to AMQQueue to create a list active of NotificationChecks is fine as a performance enhancement the problem is that on creation all alerts are 0 which means that no NotificationChecks are registered.
> In some places the AMQQueue creation is followed by Configurator.configure(...); however this does not call the set Methods but directly changes the variables so the NotificationCheck registrations are still missing.
> The virtualhost has a getConfiguredObject() which should be used to ensure all object creations are correctly configured with the commons Configuration values. However all configured objects will also need an init() method as we cannot use the constructor for things such as registering checks based on configurable values. These values are not set until later (the Configurator.configure(...) call to be exact.)
> Changes Required:
> - All Configurable object creations need to be checked to ensure that the object is correctly configured based on the commons.Configuration.
> - For consistency all Configurable objects should have an init() method to perform any final setup after the configured values have been set.
> Testing:
> This needs additional testing. In particular the configuration values for alerting need to be set via a real configuration not via the set<Notification>() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1167) Queue alerting nolonger works.
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey resolved QPID-1167.
-------------------------------
Resolution: Fixed
> Queue alerting nolonger works.
> ------------------------------
>
> Key: QPID-1167
> URL: https://issues.apache.org/jira/browse/QPID-1167
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Rob Godfrey
> Fix For: M4
>
>
> Summary:
> This was broken by commit:
> #629731 Thu Feb 21 02:09:03 PST 2008 rgodfrey
> The update to AMQQueue to create a list active of NotificationChecks is fine as a performance enhancement the problem is that on creation all alerts are 0 which means that no NotificationChecks are registered.
> In some places the AMQQueue creation is followed by Configurator.configure(...); however this does not call the set Methods but directly changes the variables so the NotificationCheck registrations are still missing.
> The virtualhost has a getConfiguredObject() which should be used to ensure all object creations are correctly configured with the commons Configuration values. However all configured objects will also need an init() method as we cannot use the constructor for things such as registering checks based on configurable values. These values are not set until later (the Configurator.configure(...) call to be exact.)
> Changes Required:
> - All Configurable object creations need to be checked to ensure that the object is correctly configured based on the commons.Configuration.
> - For consistency all Configurable objects should have an init() method to perform any final setup after the configured values have been set.
> Testing:
> This needs additional testing. In particular the configuration values for alerting need to be set via a real configuration not via the set<Notification>() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1167) Queue alerting nolonger works.
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner resolved QPID-1167.
---------------------------------
Resolution: Fixed
> Queue alerting nolonger works.
> ------------------------------
>
> Key: QPID-1167
> URL: https://issues.apache.org/jira/browse/QPID-1167
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: M2.1
> Reporter: Martin Ritchie
> Assignee: Aidan Skinner
> Priority: Blocker
> Fix For: M3
>
>
> Summary:
> This was broken by commit:
> #629731 Thu Feb 21 02:09:03 PST 2008 rgodfrey
> The update to AMQQueue to create a list active of NotificationChecks is fine as a performance enhancement the problem is that on creation all alerts are 0 which means that no NotificationChecks are registered.
> In some places the AMQQueue creation is followed by Configurator.configure(...); however this does not call the set Methods but directly changes the variables so the NotificationCheck registrations are still missing.
> The virtualhost has a getConfiguredObject() which should be used to ensure all object creations are correctly configured with the commons Configuration values. However all configured objects will also need an init() method as we cannot use the constructor for things such as registering checks based on configurable values. These values are not set until later (the Configurator.configure(...) call to be exact.)
> Changes Required:
> - All Configurable object creations need to be checked to ensure that the object is correctly configured based on the commons.Configuration.
> - For consistency all Configurable objects should have an init() method to perform any final setup after the configured values have been set.
> Testing:
> This needs additional testing. In particular the configuration values for alerting need to be set via a real configuration not via the set<Notification>() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (QPID-1167) Queue alerting nolonger works.
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner reopened QPID-1167:
---------------------------------
Requires systest to:
start broker
configure alerting
trigger alerting
check that alerts are generated properly
> Queue alerting nolonger works.
> ------------------------------
>
> Key: QPID-1167
> URL: https://issues.apache.org/jira/browse/QPID-1167
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Affects Versions: M4
> Reporter: Martin Ritchie
> Assignee: Aidan Skinner
> Priority: Blocker
> Fix For: M4
>
>
> Summary:
> This was broken by commit:
> #629731 Thu Feb 21 02:09:03 PST 2008 rgodfrey
> The update to AMQQueue to create a list active of NotificationChecks is fine as a performance enhancement the problem is that on creation all alerts are 0 which means that no NotificationChecks are registered.
> In some places the AMQQueue creation is followed by Configurator.configure(...); however this does not call the set Methods but directly changes the variables so the NotificationCheck registrations are still missing.
> The virtualhost has a getConfiguredObject() which should be used to ensure all object creations are correctly configured with the commons Configuration values. However all configured objects will also need an init() method as we cannot use the constructor for things such as registering checks based on configurable values. These values are not set until later (the Configurator.configure(...) call to be exact.)
> Changes Required:
> - All Configurable object creations need to be checked to ensure that the object is correctly configured based on the commons.Configuration.
> - For consistency all Configurable objects should have an init() method to perform any final setup after the configured values have been set.
> Testing:
> This needs additional testing. In particular the configuration values for alerting need to be set via a real configuration not via the set<Notification>() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1167) Queue alerting nolonger works.
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner updated QPID-1167:
--------------------------------
Priority: Blocker (was: Major)
> Queue alerting nolonger works.
> ------------------------------
>
> Key: QPID-1167
> URL: https://issues.apache.org/jira/browse/QPID-1167
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: M2.1
> Reporter: Martin Ritchie
> Priority: Blocker
> Fix For: M3
>
>
> Summary:
> This was broken by commit:
> #629731 Thu Feb 21 02:09:03 PST 2008 rgodfrey
> The update to AMQQueue to create a list active of NotificationChecks is fine as a performance enhancement the problem is that on creation all alerts are 0 which means that no NotificationChecks are registered.
> In some places the AMQQueue creation is followed by Configurator.configure(...); however this does not call the set Methods but directly changes the variables so the NotificationCheck registrations are still missing.
> The virtualhost has a getConfiguredObject() which should be used to ensure all object creations are correctly configured with the commons Configuration values. However all configured objects will also need an init() method as we cannot use the constructor for things such as registering checks based on configurable values. These values are not set until later (the Configurator.configure(...) call to be exact.)
> Changes Required:
> - All Configurable object creations need to be checked to ensure that the object is correctly configured based on the commons.Configuration.
> - For consistency all Configurable objects should have an init() method to perform any final setup after the configured values have been set.
> Testing:
> This needs additional testing. In particular the configuration values for alerting need to be set via a real configuration not via the set<Notification>() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1167) Queue alerting nolonger works.
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner updated QPID-1167:
--------------------------------
Status: Ready To Review (was: In Progress)
> Queue alerting nolonger works.
> ------------------------------
>
> Key: QPID-1167
> URL: https://issues.apache.org/jira/browse/QPID-1167
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: M2.1
> Reporter: Martin Ritchie
> Assignee: Aidan Skinner
> Priority: Blocker
> Fix For: M3
>
>
> Summary:
> This was broken by commit:
> #629731 Thu Feb 21 02:09:03 PST 2008 rgodfrey
> The update to AMQQueue to create a list active of NotificationChecks is fine as a performance enhancement the problem is that on creation all alerts are 0 which means that no NotificationChecks are registered.
> In some places the AMQQueue creation is followed by Configurator.configure(...); however this does not call the set Methods but directly changes the variables so the NotificationCheck registrations are still missing.
> The virtualhost has a getConfiguredObject() which should be used to ensure all object creations are correctly configured with the commons Configuration values. However all configured objects will also need an init() method as we cannot use the constructor for things such as registering checks based on configurable values. These values are not set until later (the Configurator.configure(...) call to be exact.)
> Changes Required:
> - All Configurable object creations need to be checked to ensure that the object is correctly configured based on the commons.Configuration.
> - For consistency all Configurable objects should have an init() method to perform any final setup after the configured values have been set.
> Testing:
> This needs additional testing. In particular the configuration values for alerting need to be set via a real configuration not via the set<Notification>() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (QPID-1167) Queue alerting nolonger works.
Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aidan Skinner reassigned QPID-1167:
-----------------------------------
Assignee: Aidan Skinner (was: Martin Ritchie)
> Queue alerting nolonger works.
> ------------------------------
>
> Key: QPID-1167
> URL: https://issues.apache.org/jira/browse/QPID-1167
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: M2.1
> Reporter: Martin Ritchie
> Assignee: Aidan Skinner
> Priority: Blocker
> Fix For: M3
>
>
> Summary:
> This was broken by commit:
> #629731 Thu Feb 21 02:09:03 PST 2008 rgodfrey
> The update to AMQQueue to create a list active of NotificationChecks is fine as a performance enhancement the problem is that on creation all alerts are 0 which means that no NotificationChecks are registered.
> In some places the AMQQueue creation is followed by Configurator.configure(...); however this does not call the set Methods but directly changes the variables so the NotificationCheck registrations are still missing.
> The virtualhost has a getConfiguredObject() which should be used to ensure all object creations are correctly configured with the commons Configuration values. However all configured objects will also need an init() method as we cannot use the constructor for things such as registering checks based on configurable values. These values are not set until later (the Configurator.configure(...) call to be exact.)
> Changes Required:
> - All Configurable object creations need to be checked to ensure that the object is correctly configured based on the commons.Configuration.
> - For consistency all Configurable objects should have an init() method to perform any final setup after the configured values have been set.
> Testing:
> This needs additional testing. In particular the configuration values for alerting need to be set via a real configuration not via the set<Notification>() methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.