You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/06/23 00:20:54 UTC
[GitHub] [incubator-mxnet] barry-jin opened a new pull request #20375: [2.0] Adopt interleaved_matmul_* into npx namespace
barry-jin opened a new pull request #20375:
URL: https://github.com/apache/incubator-mxnet/pull/20375
## Description ##
Part1 of feature request #20373
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ptrendx commented on pull request #20375: [2.0] Adopt interleaved_matmul_* into npx namespace
Posted by GitBox <gi...@apache.org>.
ptrendx commented on pull request #20375:
URL: https://github.com/apache/incubator-mxnet/pull/20375#issuecomment-868215426
Would it be more beneficial to have the full multihead attention primitive exposed in the API instead (it could still be implemented by the interleaved matmuls)? Both Keras and pyTorch have it as a layer, and this could make the usage easier. What do you think @barry-jin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] fhieber commented on pull request #20375: [2.0] Adopt interleaved_matmul_* into npx namespace
Posted by GitBox <gi...@apache.org>.
fhieber commented on pull request #20375:
URL: https://github.com/apache/incubator-mxnet/pull/20375#issuecomment-873911661
Can this be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] fhieber commented on pull request #20375: [2.0] Adopt interleaved_matmul_* into npx namespace
Posted by GitBox <gi...@apache.org>.
fhieber commented on pull request #20375:
URL: https://github.com/apache/incubator-mxnet/pull/20375#issuecomment-868284387
> Would it be more beneficial to have the full multihead attention primitive exposed in the API instead (it could still be implemented by the interleaved matmuls)? Both Keras and pyTorch have it as a layer, and this could make the usage easier. What do you think @barry-jin?
Can we have both? We'd like to upgrade Sockeye to MX2 without changing too many things at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] fhieber commented on pull request #20375: [2.0] Adopt interleaved_matmul_* into npx namespace
Posted by GitBox <gi...@apache.org>.
fhieber commented on pull request #20375:
URL: https://github.com/apache/incubator-mxnet/pull/20375#issuecomment-873911661
Can this be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin edited a comment on pull request #20375: [2.0] Adopt interleaved_matmul_* into npx namespace
Posted by GitBox <gi...@apache.org>.
barry-jin edited a comment on pull request #20375:
URL: https://github.com/apache/incubator-mxnet/pull/20375#issuecomment-868687059
@ptrendx Thanks for bringing it up. It's a good idea to have multihead attention layer in gluon and I will add it in a seperate PR.
@fhieber Yes, we can have both, a high level multihead attention layer and low level interleaved_matmul_* operators in `npx` name space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] barry-jin commented on pull request #20375: [2.0] Adopt interleaved_matmul_* into npx namespace
Posted by GitBox <gi...@apache.org>.
barry-jin commented on pull request #20375:
URL: https://github.com/apache/incubator-mxnet/pull/20375#issuecomment-868687059
@ptrendx Thanks for bringing it up. It's a good idea to have multihead attention layer in gluon and I will add it in this PR.
@fhieber Yes, we can have both, a high level multihead attention layer and low level interleaved_matmul_* operators in `npx` name space.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu merged pull request #20375: [2.0] Adopt interleaved_matmul_* into npx namespace
Posted by GitBox <gi...@apache.org>.
leezu merged pull request #20375:
URL: https://github.com/apache/incubator-mxnet/pull/20375
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20375: [2.0] Adopt interleaved_matmul_* into npx namespace
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20375:
URL: https://github.com/apache/incubator-mxnet/pull/20375#issuecomment-866423618
Hey @barry-jin , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [website, sanity, edge, clang, windows-gpu, miscellaneous, centos-cpu, unix-cpu, windows-cpu, unix-gpu, centos-gpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org